fix: avoid invoking onError hook when aborted handler resolves (#4631)

meyfa · web-flow · commit da9ace5ef2f5 · 2023-03-20T09:54:26.000+01:00
Fixes #4626. When a client aborts the request while the route handler is still processing, this no longer triggers an error when the route handler finishes processing.
diff --git a/lib/route.js b/lib/route.js
@@ -513,7 +513,6 @@ function handleOnRequestAbortHooksErrors (reply, err) {
   if (err) {
     reply.log.error({ err }, 'onRequestAborted hook failed')
   }
-  reply[kReplyIsError] = true
 }
 
 function handleTimeout () {
diff --git a/test/hooks.test.js b/test/hooks.test.js
@@ -3413,7 +3413,7 @@ test('onRequestAbort should be triggered', t => {
   const fastify = Fastify()
   let order = 0
 
-  t.plan(9)
+  t.plan(7)
   t.teardown(() => fastify.close())
 
   fastify.addHook('onRequestAbort', function (req, done) {
@@ -3424,8 +3424,7 @@ test('onRequestAbort should be triggered', t => {
   })
 
   fastify.addHook('onError', function hook (request, reply, error, done) {
-    t.same(error, { hello: 'world' }, 'onError should be called')
-    t.ok(request.raw.aborted, 'request should be aborted')
+    t.fail('onError should not be called')
     done()
   })
 

Original file line number	Diff line number	Diff line change
`@@ -513,7 +513,6 @@ function handleOnRequestAbortHooksErrors (reply, err) {`
`513`	`513`	`if (err) {`
`514`	`514`	`reply.log.error({ err }, 'onRequestAborted hook failed')`
`515`	`515`	`}`
`516`		`- reply[kReplyIsError] = true`
`517`	`516`	`}`
`518`	`517`
`519`	`518`	`function handleTimeout () {`