Merge pull request #236 from caioaao/fix-exc-monad

sovelten · web-flow · commit 6dda7e7a7477 · 2020-03-02T15:46:53.000-03:00
Fix exception monad to catch any throwable instead of only exceptions
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,11 @@
 # Changelog #
 
+## Version 2.3.5
+
+Date: 2020-02-21
+
+- Change exception monad to catch all throwables instead of exceptions only
+
 ## Version 2.3.4
 
 Date: 2020-02-11
diff --git a/project.clj b/project.clj
@@ -1,4 +1,4 @@
-(defproject funcool/cats "2.3.4"
+(defproject funcool/cats "2.3.5"
   :description "Category Theory abstractions for Clojure"
   :url         "https://github.com/funcool/cats"
   :license {:name "BSD (2 Clause)"
diff --git a/src/cats/monad/exception.cljc b/src/cats/monad/exception.cljc
@@ -73,7 +73,7 @@
   "Return true if `v` is an instance of
   the Throwable or js/Error type."
   [e]
-  (instance? #?(:clj Exception :cljs js/Error) e))
+  (instance? #?(:clj Throwable :cljs js/Error) e))
 
 ;; --- Types and implementations.
 
@@ -199,7 +199,7 @@
         (throwable? result) (failure result)
         (exception? result) result
         :else (success result)))
-    (catch #?(:clj Exception
+    (catch #?(:clj Throwable
               :cljs js/Error) e (failure e))))
 
 (defn ^{:no-doc true}

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-(defproject funcool/cats "2.3.4"`
	`1`	`+(defproject funcool/cats "2.3.5"`
`2`	`2`	`:description "Category Theory abstractions for Clojure"`
`3`	`3`	`:url "https://github.com/funcool/cats"`
`4`	`4`	`:license {:name "BSD (2 Clause)"`