Spec: Move outputContext to XRRenderState #536
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| 1. If |prevSession| is equal to |session| abort these steps. | ||
| 1. If |prevSession| is not <code>null</code>: | ||
| 1. If |prevSession|'s {{XRSession/renderState}}'s {{XRRenderState/outputContext}} is equal to |context| set |prevSession|'s {{XRSession/renderState}}'s {{XRRenderState/outputContext}} to <code>null</code>. | ||
| 1. Set |context|'s [=XRPresentationContext/session=] to |session|. |
There was a problem hiding this comment.
If removing the output context from |prevSession| does need to be queued, does this last step also need to be waited on?
toji
force-pushed
the
spec-output-context
branch
from
9fc4e21 to
0875bb5
Compare
NellWaliczek
approved these changes
Mar 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also documents the algorithm for removing the ouputContext from previously bound sessions when a new session has been associated.