Skip to content

x/tools/gopls/internal/test/marker: data race in shutdown #74532

Closed
@gopherbot

Description

@gopherbot
#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/internal/test/marker" && `WARNING: DATA RACE`

Issue created automatically to collect these failures.

Example (log):

=== RUN   Test/foldingrange/a_lineonly.txt
=== PAUSE Test/foldingrange/a_lineonly.txt
=== CONT  Test/foldingrange/a_lineonly.txt
==================
WARNING: DATA RACE
Write at 0x00c01238f5f0 by goroutine 314:
  runtime.recvDirect()
      /Users/swarming/.swarming/w/ir/x/w/goroot/src/runtime/chan.go:405 +0x7c
  golang.org/x/tools/gopls/internal/test/integration.(*Env).Close()
      /Users/swarming/.swarming/w/ir/x/w/targetrepo2258331998/gopls/internal/test/integration/wrappers.go:644 +0x338
...
      /Users/swarming/.swarming/w/ir/x/w/targetrepo2258331998/gopls/internal/test/marker/marker_test.go:1016 +0xc1c
  golang.org/x/tools/gopls/internal/test/marker.Test.func1()
      /Users/swarming/.swarming/w/ir/x/w/targetrepo2258331998/gopls/internal/test/marker/marker_test.go:191 +0xaac
  testing.tRunner()
      /Users/swarming/.swarming/w/ir/x/w/goroot/src/testing/testing.go:1934 +0x164
  testing.(*T).Run.gowrap1()
      /Users/swarming/.swarming/w/ir/x/w/goroot/src/testing/testing.go:1997 +0x3c
==================
    testing.go:1617: race detected during execution of test
--- FAIL: Test/foldingrange/a_lineonly.txt (2.70s)

watchflakes

Metadata

Metadata

Assignees

Labels

NeedsInvestigationSomeone must examine and confirm this is a valid issue and not a duplicate of an existing one.ToolsThis label describes issues relating to any tools in the x/tools repository.goplsIssues related to the Go language server, gopls.

Type

No type

Projects

Status

Done

Relationships

None yet

Development

No branches or pull requests

Issue actions