Skip to content

x/tools/gopls/internal/test/integration: obviate CleanModCache by making Snapshot.RunGoCommand honor GOMODCACHE #74595

Open
@adonovan

Description

@adonovan

This function (moved to its current location in https://go.dev/cl/682717) is required to clean up the module cache because Sandbox.RunGoCommand doesn't honor the GOMODCACHE environment variable provided by settings.env; in fact it explicitly clears it.

The task of this issue is to honor that variable, and eliminate the need for CleanModCache (see also the other hacks in the tests of the above CL related to the same problem), or to document more clearly why this is impossible.

Metadata

Metadata

Assignees

No one assigned

    Labels

    FeatureRequestIssues asking for a new feature that does not need a proposal.ToolsThis label describes issues relating to any tools in the x/tools repository.goplsIssues related to the Go language server, gopls.

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions