[Tizen] Properly implement BLEManagerImpl::_NumConnections #39965
+133
−166
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
The pull request implements _NumConnections to return the actual number of BLE connections. The review focuses on a potential race condition when accessing the shared connection map and suggests adding thread synchronization using the platform's locking mechanism to ensure data integrity.
|
PR #39965: Size comparison from c0a78ce to 0258186 Full report (70 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
arkq
force-pushed
the
tizen-ble-con-count
branch
from
0258186 to
208374f
Compare
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request implements _NumConnections by switching from GHashTable to std::unordered_map for managing BLE connections, which improves type safety and simplifies the code. The PR also fixes a memory leak in _GetDeviceName and simplifies parameter validation in several functions. There is a critical operator precedence bug that needs to be addressed, and a high-severity logic issue in CloseConnection that could lead to race conditions and confusing logs.
Comment on lines
+1189
to
+1192
| int ret = bt_gatt_disconnect(conId->peerAddr.c_str()); | ||
| VerifyOrExit(ret == BT_ERROR_NONE, ChipLogError(DeviceLayer, "bt_gatt_disconnect() failed: %s", get_error_message(ret))); | ||
|
|
||
| RemoveConnectionData(conId->peerAddr); | ||
| RemoveConnection(conId->peerAddr.c_str()); |
There was a problem hiding this comment.
Calling RemoveConnection here can lead to a race condition and confusing logs. The bt_gatt_disconnect function is asynchronous and will trigger a ConnectionStateChangedCb callback upon completion, which in turn calls HandleConnectionEvent and then RemoveConnection.
This means the connection is removed twice: once synchronously here, and again asynchronously in the event handler. While the current implementation of RemoveConnection is safe against a double-free, it will log an error when the connection is not found on the second call. To avoid this, I recommend removing the synchronous call to RemoveConnection and relying solely on the event handler for cleanup. This ensures a single, consistent point of state management for connection removal.
|
PR #39965: Size comparison from ad2e3f5 to b867e84 Increases above 0.2%:
Full report (59 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The
chip::DeviceLayer::ConnectivityMgr().NumBLEConnections()always returns 0 because underlying implementation was incorrect.Changes
Testing
Locally verified that the application can check whether there is an ongoing BLE connection.