Make 'true' a truthy value for window.open boolean features #7425
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zcorpan
added
needs tests
|
( |
domenic
approved these changes
Jan 4, 2022
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Mar 2, 2022
Prior to this CL, window.open(url, '', 'noopener=true') would treat 'noopener=true' as if noopener is false. This is currently per-spec [1] but there is a desire [2][3] to change that. [1] https://html.spec.whatwg.org/multipage/window-object.html#concept-window-open-features-parse-boolean [2] whatwg/html#7425 [3] whatwg/html#7399 Fixed: 1277613 Change-Id: I5b3a7e985a9bb392c2150846b50369cfcd9b05fa
|
Filed https://bugzilla.mozilla.org/show_bug.cgi?id=1757969 for Firefox, and I'm working on it |
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Mar 3, 2022
Prior to this CL, window.open(url, '', 'noopener=true') would treat 'noopener=true' as if noopener is false. This is currently per-spec [1] but there is a desire [2][3] to change that. [1] https://html.spec.whatwg.org/multipage/window-object.html#concept-window-open-features-parse-boolean [2] whatwg/html#7425 [3] whatwg/html#7399 Fixed: 1277613 Change-Id: I5b3a7e985a9bb392c2150846b50369cfcd9b05fa
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Mar 3, 2022
Prior to this CL, window.open(url, '', 'noopener=true') would treat 'noopener=true' as if noopener is false. This is currently per-spec [1] but there is a desire [2][3] to change that. The I2S is here: https://groups.google.com/a/chromium.org/g/blink-dev/c/ePJ4GE6VzVc/m/urs3-4rHDAAJ [1] https://html.spec.whatwg.org/multipage/window-object.html#concept-window-open-features-parse-boolean [2] whatwg/html#7425 [3] whatwg/html#7399 Fixed: 1277613 Change-Id: I5b3a7e985a9bb392c2150846b50369cfcd9b05fa
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Mar 4, 2022
Prior to this CL, window.open(url, '', 'noopener=true') would treat 'noopener=true' as if noopener is false. This is currently per-spec [1] but there is a desire [2][3] to change that. The I2S is here: https://groups.google.com/a/chromium.org/g/blink-dev/c/ePJ4GE6VzVc/m/urs3-4rHDAAJ [1] https://html.spec.whatwg.org/multipage/window-object.html#concept-window-open-features-parse-boolean [2] whatwg/html#7425 [3] whatwg/html#7399 Fixed: 1277613 Change-Id: I5b3a7e985a9bb392c2150846b50369cfcd9b05fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3495659 Reviewed-by: Joey Arhar <jarhar@chromium.org> Commit-Queue: Mason Freed <masonf@chromium.org> Cr-Commit-Position: refs/heads/main@{#977722}
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Mar 4, 2022
Prior to this CL, window.open(url, '', 'noopener=true') would treat 'noopener=true' as if noopener is false. This is currently per-spec [1] but there is a desire [2][3] to change that. The I2S is here: https://groups.google.com/a/chromium.org/g/blink-dev/c/ePJ4GE6VzVc/m/urs3-4rHDAAJ [1] https://html.spec.whatwg.org/multipage/window-object.html#concept-window-open-features-parse-boolean [2] whatwg/html#7425 [3] whatwg/html#7399 Fixed: 1277613 Change-Id: I5b3a7e985a9bb392c2150846b50369cfcd9b05fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3495659 Reviewed-by: Joey Arhar <jarhar@chromium.org> Commit-Queue: Mason Freed <masonf@chromium.org> Cr-Commit-Position: refs/heads/main@{#977722}
domenic
added
addition/proposal
domenic
approved these changes
Mar 7, 2022
|
Merged and filed a bug for WebKit. Yay! Also thanks for working on the extra tests about the value space; they seem nice and comprehensive. |
webkit-commit-queue
pushed a commit
to WebKit/WebKit
that referenced
this pull request
Mar 7, 2022
https://bugs.webkit.org/show_bug.cgi?id=237530 Reviewed by Alex Christensen. LayoutTests/imported/w3c: Import WPT test coverage. * resources/resource-files.json: * web-platform-tests/html/browsers/the-window-object/apis-for-creating-and-navigating-browsing-contexts-by-name/open-features-is-popup-condition.html: * web-platform-tests/html/browsers/the-window-object/support/w3c-import.log: * web-platform-tests/html/browsers/the-window-object/support/windowFeature-values-target.html: Added. * web-platform-tests/html/browsers/the-window-object/w3c-import.log: * web-platform-tests/html/browsers/the-window-object/window-open-noopener.html: * web-platform-tests/html/browsers/the-window-object/window-open-windowfeatures-values-expected.txt: Added. * web-platform-tests/html/browsers/the-window-object/window-open-windowfeatures-values.html: Added. Source/WebCore: Make "true" count as truthy in window.open()'s boolean features, as per: - whatwg/html#7425 Test: imported/w3c/web-platform-tests/html/browsers/the-window-object/window-open-windowfeatures-values.html * page/WindowFeatures.cpp: (WebCore::setWindowFeature): LayoutTests: * tests-options.json: Canonical link: https://commits.webkit.org/248130@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@290899 268f45cc-cd09-0410-ab3c-d52691b4dbfc
zcorpan
added a commit
to zcorpan/content
that referenced
this pull request
Mar 8, 2022
3 tasks
zcorpan
removed
the
impacts documentation
|
zcorpan
added
the
impacts documentation
annulen
pushed a commit
to qtwebkit/qtwebkit
that referenced
this pull request
Mar 8, 2022
https://bugs.webkit.org/show_bug.cgi?id=237530 Reviewed by Alex Christensen. LayoutTests/imported/w3c: Import WPT test coverage. * resources/resource-files.json: * web-platform-tests/html/browsers/the-window-object/apis-for-creating-and-navigating-browsing-contexts-by-name/open-features-is-popup-condition.html: * web-platform-tests/html/browsers/the-window-object/support/w3c-import.log: * web-platform-tests/html/browsers/the-window-object/support/windowFeature-values-target.html: Added. * web-platform-tests/html/browsers/the-window-object/w3c-import.log: * web-platform-tests/html/browsers/the-window-object/window-open-noopener.html: * web-platform-tests/html/browsers/the-window-object/window-open-windowfeatures-values-expected.txt: Added. * web-platform-tests/html/browsers/the-window-object/window-open-windowfeatures-values.html: Added. Source/WebCore: Make "true" count as truthy in window.open()'s boolean features, as per: - whatwg/html#7425 Test: imported/w3c/web-platform-tests/html/browsers/the-window-object/window-open-windowfeatures-values.html * page/WindowFeatures.cpp: (WebCore::setWindowFeature): LayoutTests: * tests-options.json: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@290899 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Elchi3
pushed a commit
to mdn/content
that referenced
this pull request
Mar 21, 2022
3 tasks
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Mar 22, 2022
…dowFeatures, a=testonly Automatic update from web-platform-tests Add "true" to truthy values list for windowFeatures Prior to this CL, window.open(url, '', 'noopener=true') would treat 'noopener=true' as if noopener is false. This is currently per-spec [1] but there is a desire [2][3] to change that. The I2S is here: https://groups.google.com/a/chromium.org/g/blink-dev/c/ePJ4GE6VzVc/m/urs3-4rHDAAJ [1] https://html.spec.whatwg.org/multipage/window-object.html#concept-window-open-features-parse-boolean [2] whatwg/html#7425 [3] whatwg/html#7399 Fixed: 1277613 Change-Id: I5b3a7e985a9bb392c2150846b50369cfcd9b05fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3495659 Reviewed-by: Joey Arhar <jarhar@chromium.org> Commit-Queue: Mason Freed <masonf@chromium.org> Cr-Commit-Position: refs/heads/main@{#977722} -- wpt-commits: 2026041556d8c61e167d0a0d3d0bbbeaf99dcd70 wpt-pr: 33029
aosmond
pushed a commit
to aosmond/gecko
that referenced
this pull request
Mar 26, 2022
…dowFeatures, a=testonly Automatic update from web-platform-tests Add "true" to truthy values list for windowFeatures Prior to this CL, window.open(url, '', 'noopener=true') would treat 'noopener=true' as if noopener is false. This is currently per-spec [1] but there is a desire [2][3] to change that. The I2S is here: https://groups.google.com/a/chromium.org/g/blink-dev/c/ePJ4GE6VzVc/m/urs3-4rHDAAJ [1] https://html.spec.whatwg.org/multipage/window-object.html#concept-window-open-features-parse-boolean [2] whatwg/html#7425 [3] whatwg/html#7399 Fixed: 1277613 Change-Id: I5b3a7e985a9bb392c2150846b50369cfcd9b05fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3495659 Reviewed-by: Joey Arhar <jarhar@chromium.org> Commit-Queue: Mason Freed <masonf@chromium.org> Cr-Commit-Position: refs/heads/main@{#977722} -- wpt-commits: 2026041556d8c61e167d0a0d3d0bbbeaf99dcd70 wpt-pr: 33029
This was referenced May 12, 2022
This was referenced Jul 19, 2022
bytes-crafter
pushed a commit
to openFyde/chromium
that referenced
this pull request
May 28, 2025
Prior to this CL, window.open(url, '', 'noopener=true') would treat 'noopener=true' as if noopener is false. This is currently per-spec [1] but there is a desire [2][3] to change that. The I2S is here: https://groups.google.com/a/chromium.org/g/blink-dev/c/ePJ4GE6VzVc/m/urs3-4rHDAAJ [1] https://html.spec.whatwg.org/multipage/window-object.html#concept-window-open-features-parse-boolean [2] whatwg/html#7425 [3] whatwg/html#7399 Fixed: 1277613 Change-Id: I5b3a7e985a9bb392c2150846b50369cfcd9b05fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3495659 Reviewed-by: Joey Arhar <jarhar@chromium.org> Commit-Queue: Mason Freed <masonf@chromium.org> Cr-Commit-Position: refs/heads/main@{#977722}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7399.
(See WHATWG Working Mode: Changes for more details.)
/window-object.html ( diff )