More theming work #19995
Merged
More theming work #19995
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hopefully this will allow the cleanup of the recent hacky solution of the game list settings menu as well. EDIT: I see you're way ahead of me -- it's already done. 😄 |
NABN00B
reviewed
Feb 17, 2025
| @@ -148,8 +148,8 @@ static void LoadThemeInfo(const std::vector<Path> &directories) { | |||
| section.Get("PopupStyleBg", &info.uPopupStyleBg, info.uPopupStyleBg); | |||
| section.Get("TooltipStyleFg", &info.uTooltipStyleFg, info.uTooltipStyleFg); // Backwards compat | |||
| section.Get("TooltipStyleBg", &info.uTooltipStyleBg, info.uTooltipStyleBg); | |||
| section.Get("PopupHeaderStyleFg", &info.uPopupHeaderStyleFg, info.uItemStyleFg); // Backwards compat | |||
| section.Get("PopupHeaderStyleBg", &info.uPopupHeaderStyleBg, info.uPopupHeaderStyleBg); | |||
| section.Get("PopupHeaderStyleFg", &info.uPopupTitleStyleFg, info.uItemStyleFg); // Backwards compat | |||
There was a problem hiding this comment.
You forgot to change the first parameter, it's still looking for PopupHeader* in the inis.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a mechanism for a view to know if it's in a popup, as mentioned in #18802 .
Uses it in a few places.
Also, I changed my mind on the naming ofr PopupHeaderStyle.
(This doesn't solve the slider color issue)