libkirk concurrency fixes #20453
Merged
libkirk concurrency fixes #20453
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "kirk" (PSP decryption) engine state was global, causing bad clashes when we were doing things like decrypting NPDRM images (like (legitimately) downloaded games from PSN). So if you had a few of those, the UI could crash if you browsed to them in the game browser.
Now, there's a kirk instance for in-game use, and NPDRM reader contexts get their own ones. This resolves the issue and stops the crashes.
This commit series starts with a bunch of const cleanup, and then extracts the global state into a struct.
Big thanks to "its just wario" from Discord.