Skip to content

plugins.afreeca: update '_get_channel_info' with 'bno', plugin cleanup #3408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 13, 2020

Conversation

back-to
Copy link
Collaborator

@back-to back-to commented Dec 11, 2020

  • use broadcast number for _get_channel_info
  • use FilteredHLSStream instead of --hls-segment-ignore-names
  • save cookies for a user session
  • add new option --afreeca-purge-credentials
  • general plugin cleanup

closes #3407

- use broadcast number for _get_channel_info
- use FilteredHLSStream instead of --hls-segment-ignore-names
- save cookies for a user session
- add new option --afreeca-purge-credentials
- general plugin cleanup
@back-to back-to added plugin issue A Plugin does not work correctly plugin enhancement A new feature for a working Plugin cleanup labels Dec 11, 2020
Copy link
Member

@bastimeyer bastimeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pulbitz

Only certain afreecatv streamer get this error.

Could you please check whether these changes are working for you, so that this can be merged and #3407 be closed?

_re_bno = re.compile(r"var nBroadNo = (?P<bno>\d+);")
_re_url = re.compile(r"https?://play\.afreecatv\.com/(?P<username>\w+)(?:/(?P<bno>:\d+))?")

CHANNEL_API_URL = "http://live.afreecatv.com/afreeca/player_live_api.php"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if it's worth it, but the API URL could be changed to https and https added to _schema_stream down below. What's required for this to work is disabling the TLS validation via self.session.set_option("http-ssl-verify", False).

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there website uses http in the web browser,
adding https here with http-ssl-verify", False is currently unnecessary

back-to added a commit to back-to/streamlink that referenced this pull request Dec 13, 2020
It has some downsides such as `--hls-timeout`,
Plugin specified FilteredHLSStream should be used instead.

streamlink#3187

---

Afreeca Plugin as an Example

streamlink#3408

---

Revert streamlink#1432
@back-to back-to merged commit c0baa95 into streamlink:master Dec 13, 2020
@back-to back-to deleted the afreeca branch December 13, 2020 15:36
Billy2011 pushed a commit to Billy2011/streamlink-27 that referenced this pull request Dec 14, 2020
…n cleanup (streamlink#3408)

- use broadcast number for _get_channel_info
- use FilteredHLSStream instead of --hls-segment-ignore-names
- save cookies for a user session
- add new option --afreeca-purge-credentials
- general plugin cleanup
Billy2011 pushed a commit to Billy2011/streamlink-27 that referenced this pull request Dec 14, 2020
…n cleanup (streamlink#3408)

- use broadcast number for _get_channel_info
- use FilteredHLSStream instead of --hls-segment-ignore-names
- save cookies for a user session
- add new option --afreeca-purge-credentials
- general plugin cleanup
Billy2011 pushed a commit to Billy2011/streamlink-27 that referenced this pull request Dec 17, 2020
…n cleanup (streamlink#3408)

- use broadcast number for _get_channel_info
- use FilteredHLSStream instead of --hls-segment-ignore-names
- save cookies for a user session
- add new option --afreeca-purge-credentials
- general plugin cleanup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup plugin enhancement A new feature for a working Plugin plugin issue A Plugin does not work correctly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

afreecatv.com
2 participants