-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
plugins.afreeca: update '_get_channel_info' with 'bno', plugin cleanup #3408
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- use broadcast number for _get_channel_info - use FilteredHLSStream instead of --hls-segment-ignore-names - save cookies for a user session - add new option --afreeca-purge-credentials - general plugin cleanup
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
_re_bno = re.compile(r"var nBroadNo = (?P<bno>\d+);") | ||
_re_url = re.compile(r"https?://play\.afreecatv\.com/(?P<username>\w+)(?:/(?P<bno>:\d+))?") | ||
|
||
CHANNEL_API_URL = "http://live.afreecatv.com/afreeca/player_live_api.php" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if it's worth it, but the API URL could be changed to https
and https
added to _schema_stream
down below. What's required for this to work is disabling the TLS validation via self.session.set_option("http-ssl-verify", False)
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there website uses http
in the web browser,
adding https
here with http-ssl-verify", False
is currently unnecessary
It has some downsides such as `--hls-timeout`, Plugin specified FilteredHLSStream should be used instead. streamlink#3187 --- Afreeca Plugin as an Example streamlink#3408 --- Revert streamlink#1432
…n cleanup (streamlink#3408) - use broadcast number for _get_channel_info - use FilteredHLSStream instead of --hls-segment-ignore-names - save cookies for a user session - add new option --afreeca-purge-credentials - general plugin cleanup
…n cleanup (streamlink#3408) - use broadcast number for _get_channel_info - use FilteredHLSStream instead of --hls-segment-ignore-names - save cookies for a user session - add new option --afreeca-purge-credentials - general plugin cleanup
…n cleanup (streamlink#3408) - use broadcast number for _get_channel_info - use FilteredHLSStream instead of --hls-segment-ignore-names - save cookies for a user session - add new option --afreeca-purge-credentials - general plugin cleanup
closes #3407