Avoid pyav v14 to prevent AttributeError #1112
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes
shaform
changed the title
This reverts commit b789b5c.
shaform
changed the title
shaform
changed the title
shaform
changed the title
|
[Sorry for ghosting this PR. I've had a neat sequence of events that, unfortunately, kept me away from open-source (work deadline, vacation in China, being sick). Now I am back. I took the liberty to not just go over the PR but also checked out other changes that come with av v14, which are mostly removals of various convenience methods that used to exist before. I added changes for these here. |
FirefoxMetzger
approved these changes
Jan 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #1111.
Work around the issue described in #1111 by restricting pyav version.