Skip to content

Commit 1defc0a

Browse files
insideguiinsidegui
authored
Merge pull request #722 from insidegui/warning-cleanup-xcode16
Fix most warnings when building in Xcode 16
2 parents 68fc715 + e2dedab commit 1defc0a

20 files changed

+31
-32
lines changed

‎Packages/ConfCore/ConfCore/AppleAPIClient.swift

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@
88

99
import Foundation
1010
import Siesta
11+
import OSLog
1112

1213
// MARK: - Initialization and configuration
1314

‎Packages/ConfCore/ConfCore/Bookmark.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ public final class Bookmark: Object, HasCloudKitFields, SoftDeletable, Decodable
5353
/// The session this bookmark is associated with
5454
public let session = LinkingObjects(fromType: Session.self, property: "bookmarks")
5555

56-
public override class func primaryKey() -> String? {
56+
public override static func primaryKey() -> String? {
5757
return "identifier"
5858
}
5959

‎Packages/ConfCore/ConfCore/CloudKitHelper.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ import CloudKit
1111

1212
public final class CloudKitHelper {
1313

14-
public class func subscriptionExists(with name: String, in database: CKDatabase, completion: @escaping (Bool) -> Void) {
14+
public static func subscriptionExists(with name: String, in database: CKDatabase, completion: @escaping (Bool) -> Void) {
1515
let fetchSubscriptionOperation = CKFetchSubscriptionsOperation(subscriptionIDs: [name])
1616

1717
fetchSubscriptionOperation.fetchSubscriptionCompletionBlock = { subscriptions, error in

‎Packages/ConfCore/ConfCore/Favorite.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ public final class Favorite: Object, HasCloudKitFields, SoftDeletable {
2727
/// The session this favorite is associated with
2828
public let session = LinkingObjects(fromType: Session.self, property: "favorites")
2929

30-
public override class func primaryKey() -> String? {
30+
public override static func primaryKey() -> String? {
3131
return "identifier"
3232
}
3333

‎Packages/ConfCore/ConfCore/ScheduleSection.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ public final class ScheduleSection: Object {
1717
@objc public dynamic var representedDate: Date = .distantPast
1818
public let instances = List<SessionInstance>()
1919

20-
public override class func primaryKey() -> String {
20+
public override static func primaryKey() -> String {
2121
return "identifier"
2222
}
2323

‎Packages/ConfCore/ConfCore/SessionProgress.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ public final class SessionProgress: Object, HasCloudKitFields, SoftDeletable {
3737
/// The session this progress is associated with
3838
public let session = LinkingObjects(fromType: Session.self, property: "progresses")
3939

40-
public override class func primaryKey() -> String? {
40+
public override static func primaryKey() -> String? {
4141
return "identifier"
4242
}
4343
}

‎Packages/ConfCore/ConfCore/Storage.swift

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -155,7 +155,6 @@ public final class Storage: Logging, Signposting {
155155
// add instances and sessions to events
156156
let instancesToEvents = Self.signposter.beginInterval("store content result", id: Self.signposter.makeSignpostID(), "add instances and sessions to events")
157157
backgroundRealm.objects(Event.self).forEach { event in
158-
let instances = backgroundRealm.objects(SessionInstance.self).filter("eventIdentifier == %@", event.identifier)
159158
let sessions = backgroundRealm.objects(Session.self).filter("eventIdentifier == %@", event.identifier)
160159

161160
event.sessionInstances.removeAll()

‎WWDC.xcodeproj/project.pbxproj

Lines changed: 9 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -1353,7 +1353,7 @@
13531353
attributes = {
13541354
BuildIndependentTargetsInParallel = YES;
13551355
LastSwiftUpdateCheck = 1250;
1356-
LastUpgradeCheck = 1530;
1356+
LastUpgradeCheck = 1630;
13571357
ORGANIZATIONNAME = "Guilherme Rambo";
13581358
TargetAttributes = {
13591359
DD36A4AB1E478C6900B2EA88 = {
@@ -1857,7 +1857,6 @@
18571857
DD36A4BC1E478C6A00B2EA88 /* Debug */ = {
18581858
isa = XCBuildConfiguration;
18591859
buildSettings = {
1860-
ALWAYS_EMBED_SWIFT_STANDARD_LIBRARIES = YES;
18611860
ASSETCATALOG_COMPILER_APPICON_NAME = AppIcon;
18621861
CLANG_ENABLE_MODULES = YES;
18631862
CODE_SIGN_ENTITLEMENTS = WWDC/WWDC.entitlements;
@@ -1886,7 +1885,6 @@
18861885
DD36A4BD1E478C6A00B2EA88 /* Release */ = {
18871886
isa = XCBuildConfiguration;
18881887
buildSettings = {
1889-
ALWAYS_EMBED_SWIFT_STANDARD_LIBRARIES = YES;
18901888
ASSETCATALOG_COMPILER_APPICON_NAME = AppIcon;
18911889
CLANG_ENABLE_MODULES = YES;
18921890
CODE_SIGN_ENTITLEMENTS = WWDC/WWDC.entitlements;
@@ -1976,7 +1974,6 @@
19761974
DD5910651ECA0C17003C32A4 /* Debug_iCloud */ = {
19771975
isa = XCBuildConfiguration;
19781976
buildSettings = {
1979-
ALWAYS_EMBED_SWIFT_STANDARD_LIBRARIES = YES;
19801977
ASSETCATALOG_COMPILER_APPICON_NAME = AppIcon;
19811978
CLANG_ENABLE_MODULES = YES;
19821979
CODE_SIGN_ENTITLEMENTS = WWDC/WWDCDebug_iCloud.entitlements;
@@ -2060,7 +2057,6 @@
20602057
DD59106A1ECA0C20003C32A4 /* Release_iCloud */ = {
20612058
isa = XCBuildConfiguration;
20622059
buildSettings = {
2063-
ALWAYS_EMBED_SWIFT_STANDARD_LIBRARIES = YES;
20642060
ASSETCATALOG_COMPILER_APPICON_NAME = AppIcon;
20652061
CLANG_ENABLE_MODULES = YES;
20662062
CODE_SIGN_ENTITLEMENTS = WWDC/WWDCRelease_iCloud.entitlements;
@@ -2094,14 +2090,14 @@
20942090
CLANG_CXX_LANGUAGE_STANDARD = "gnu++14";
20952091
CLANG_ENABLE_MODULES = YES;
20962092
CLANG_ENABLE_OBJC_WEAK = YES;
2093+
CODE_SIGN_IDENTITY = "";
20972094
CODE_SIGN_STYLE = Automatic;
20982095
COMBINE_HIDPI_IMAGES = YES;
20992096
DEAD_CODE_STRIPPING = YES;
21002097
DEFINES_MODULE = YES;
21012098
DYLIB_COMPATIBILITY_VERSION = 1;
21022099
DYLIB_CURRENT_VERSION = 1027;
21032100
DYLIB_INSTALL_NAME_BASE = "@rpath";
2104-
ENABLE_MODULE_VERIFIER = YES;
21052101
GCC_C_LANGUAGE_STANDARD = gnu11;
21062102
INFOPLIST_FILE = ConfUIFoundation/Info.plist;
21072103
INSTALL_PATH = "$(LOCAL_LIBRARY_DIR)/Frameworks";
@@ -2130,14 +2126,14 @@
21302126
CLANG_CXX_LANGUAGE_STANDARD = "gnu++14";
21312127
CLANG_ENABLE_MODULES = YES;
21322128
CLANG_ENABLE_OBJC_WEAK = YES;
2129+
CODE_SIGN_IDENTITY = "";
21332130
CODE_SIGN_STYLE = Automatic;
21342131
COMBINE_HIDPI_IMAGES = YES;
21352132
DEAD_CODE_STRIPPING = YES;
21362133
DEFINES_MODULE = YES;
21372134
DYLIB_COMPATIBILITY_VERSION = 1;
21382135
DYLIB_CURRENT_VERSION = 1027;
21392136
DYLIB_INSTALL_NAME_BASE = "@rpath";
2140-
ENABLE_MODULE_VERIFIER = YES;
21412137
GCC_C_LANGUAGE_STANDARD = gnu11;
21422138
INFOPLIST_FILE = ConfUIFoundation/Info.plist;
21432139
INSTALL_PATH = "$(LOCAL_LIBRARY_DIR)/Frameworks";
@@ -2166,14 +2162,14 @@
21662162
CLANG_CXX_LANGUAGE_STANDARD = "gnu++14";
21672163
CLANG_ENABLE_MODULES = YES;
21682164
CLANG_ENABLE_OBJC_WEAK = YES;
2165+
CODE_SIGN_IDENTITY = "";
21692166
CODE_SIGN_STYLE = Automatic;
21702167
COMBINE_HIDPI_IMAGES = YES;
21712168
DEAD_CODE_STRIPPING = YES;
21722169
DEFINES_MODULE = YES;
21732170
DYLIB_COMPATIBILITY_VERSION = 1;
21742171
DYLIB_CURRENT_VERSION = 1027;
21752172
DYLIB_INSTALL_NAME_BASE = "@rpath";
2176-
ENABLE_MODULE_VERIFIER = YES;
21772173
GCC_C_LANGUAGE_STANDARD = gnu11;
21782174
INFOPLIST_FILE = ConfUIFoundation/Info.plist;
21792175
INSTALL_PATH = "$(LOCAL_LIBRARY_DIR)/Frameworks";
@@ -2200,14 +2196,14 @@
22002196
CLANG_CXX_LANGUAGE_STANDARD = "gnu++14";
22012197
CLANG_ENABLE_MODULES = YES;
22022198
CLANG_ENABLE_OBJC_WEAK = YES;
2199+
CODE_SIGN_IDENTITY = "";
22032200
CODE_SIGN_STYLE = Automatic;
22042201
COMBINE_HIDPI_IMAGES = YES;
22052202
DEAD_CODE_STRIPPING = YES;
22062203
DEFINES_MODULE = YES;
22072204
DYLIB_COMPATIBILITY_VERSION = 1;
22082205
DYLIB_CURRENT_VERSION = 1027;
22092206
DYLIB_INSTALL_NAME_BASE = "@rpath";
2210-
ENABLE_MODULE_VERIFIER = YES;
22112207
GCC_C_LANGUAGE_STANDARD = gnu11;
22122208
INFOPLIST_FILE = ConfUIFoundation/Info.plist;
22132209
INSTALL_PATH = "$(LOCAL_LIBRARY_DIR)/Frameworks";
@@ -2329,13 +2325,13 @@
23292325
isa = XCBuildConfiguration;
23302326
buildSettings = {
23312327
CLANG_ANALYZER_NUMBER_OBJECT_CONVERSION = YES_AGGRESSIVE;
2328+
CODE_SIGN_IDENTITY = "";
23322329
COMBINE_HIDPI_IMAGES = YES;
23332330
DEAD_CODE_STRIPPING = YES;
23342331
DEFINES_MODULE = YES;
23352332
DYLIB_COMPATIBILITY_VERSION = 1;
23362333
DYLIB_CURRENT_VERSION = 1027;
23372334
DYLIB_INSTALL_NAME_BASE = "@rpath";
2338-
ENABLE_MODULE_VERIFIER = YES;
23392335
FRAMEWORK_SEARCH_PATHS = (
23402336
"$(inherited)",
23412337
"$(SYSTEM_LIBRARY_DIR)/PrivateFrameworks",
@@ -2361,13 +2357,13 @@
23612357
isa = XCBuildConfiguration;
23622358
buildSettings = {
23632359
CLANG_ANALYZER_NUMBER_OBJECT_CONVERSION = YES_AGGRESSIVE;
2360+
CODE_SIGN_IDENTITY = "";
23642361
COMBINE_HIDPI_IMAGES = YES;
23652362
DEAD_CODE_STRIPPING = YES;
23662363
DEFINES_MODULE = YES;
23672364
DYLIB_COMPATIBILITY_VERSION = 1;
23682365
DYLIB_CURRENT_VERSION = 1027;
23692366
DYLIB_INSTALL_NAME_BASE = "@rpath";
2370-
ENABLE_MODULE_VERIFIER = YES;
23712367
FRAMEWORK_SEARCH_PATHS = (
23722368
"$(inherited)",
23732369
"$(SYSTEM_LIBRARY_DIR)/PrivateFrameworks",
@@ -2393,13 +2389,13 @@
23932389
isa = XCBuildConfiguration;
23942390
buildSettings = {
23952391
CLANG_ANALYZER_NUMBER_OBJECT_CONVERSION = YES_AGGRESSIVE;
2392+
CODE_SIGN_IDENTITY = "";
23962393
COMBINE_HIDPI_IMAGES = YES;
23972394
DEAD_CODE_STRIPPING = YES;
23982395
DEFINES_MODULE = YES;
23992396
DYLIB_COMPATIBILITY_VERSION = 1;
24002397
DYLIB_CURRENT_VERSION = 1027;
24012398
DYLIB_INSTALL_NAME_BASE = "@rpath";
2402-
ENABLE_MODULE_VERIFIER = YES;
24032399
FRAMEWORK_SEARCH_PATHS = (
24042400
"$(inherited)",
24052401
"$(SYSTEM_LIBRARY_DIR)/PrivateFrameworks",
@@ -2425,13 +2421,13 @@
24252421
isa = XCBuildConfiguration;
24262422
buildSettings = {
24272423
CLANG_ANALYZER_NUMBER_OBJECT_CONVERSION = YES_AGGRESSIVE;
2424+
CODE_SIGN_IDENTITY = "";
24282425
COMBINE_HIDPI_IMAGES = YES;
24292426
DEAD_CODE_STRIPPING = YES;
24302427
DEFINES_MODULE = YES;
24312428
DYLIB_COMPATIBILITY_VERSION = 1;
24322429
DYLIB_CURRENT_VERSION = 1027;
24332430
DYLIB_INSTALL_NAME_BASE = "@rpath";
2434-
ENABLE_MODULE_VERIFIER = YES;
24352431
FRAMEWORK_SEARCH_PATHS = (
24362432
"$(inherited)",
24372433
"$(SYSTEM_LIBRARY_DIR)/PrivateFrameworks",

‎WWDC.xcodeproj/xcshareddata/xcschemes/WWDC.xcscheme

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
<?xml version="1.0" encoding="UTF-8"?>
22
<Scheme
3-
LastUpgradeVersion = "1530"
3+
LastUpgradeVersion = "1630"
44
version = "1.8">
55
<BuildAction
66
parallelizeBuildables = "YES"

‎WWDC.xcodeproj/xcshareddata/xcschemes/WWDC_iCloud.xcscheme

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
<?xml version="1.0" encoding="UTF-8"?>
22
<Scheme
3-
LastUpgradeVersion = "1530"
3+
LastUpgradeVersion = "1630"
44
version = "1.3">
55
<BuildAction
66
parallelizeBuildables = "YES"

0 commit comments

Comments
 (0)