Skip to content

plugins.youtube: check VOD URLs, raise PluginError #6135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 20, 2024
Merged

plugins.youtube: check VOD URLs, raise PluginError #6135

merged 1 commit into from
Aug 20, 2024

Conversation

bastimeyer
Copy link
Member

See #6060

This adds the following error message for VOD content with 4xx HTTP error responses

This plugin does not support VOD content, try yt-dlp instead

and updates the existing error message for protected videos

This plugin does not support protected videos, try yt-dlp instead

The protected video stuff is actually useless now, but I didn't want to make any significant plugin changes, so it'll be kept.

In order to fix VOD content, we'd need to implement YouTube's adaptive stream URL signatures. As said, I'm not interested in implementing this myself, so if someone wants this to be fixed, they'll need to submit a PR with working code and be willing to keep the plugin maintained.

Live content is of course still working fine.

$ streamlink https://www.youtube.com/v/aqz-KE-bpKQ
[cli][info] Found matching plugin youtube for URL https://www.youtube.com/v/aqz-KE-bpKQ
error: This plugin does not support VOD content, try yt-dlp instead

$ streamlink https://www.youtube.com/watch?v=_YjQA4m4kLM
[cli][info] Found matching plugin youtube for URL https://www.youtube.com/watch?v=_YjQA4m4kLM
error: This plugin does not support protected videos, try yt-dlp instead

$ streamlink https://www.youtube.com/hospitalrecords
[cli][info] Found matching plugin youtube for URL https://www.youtube.com/hospitalrecords
error: This plugin does not support protected videos, try yt-dlp instead

$ streamlink https://www.youtube.com/@hospitalrecords
[cli][info] Found matching plugin youtube for URL https://www.youtube.com/@hospitalrecords
error: This plugin does not support protected videos, try yt-dlp instead

$ streamlink https://www.youtube.com/hospitalrecords/live
[cli][info] Found matching plugin youtube for URL https://www.youtube.com/hospitalrecords/live
Available streams: 144p (worst), 240p, 360p, 480p, 720p, 1080p (best)

$ streamlink https://www.youtube.com/@hospitalrecords/live
[cli][info] Found matching plugin youtube for URL https://www.youtube.com/@hospitalrecords/live
Available streams: 144p (worst), 240p, 360p, 480p, 720p, 1080p (best)

$ streamlink https://www.youtube.com/watch?v=Cwq3AFyV044
[cli][info] Found matching plugin youtube for URL https://www.youtube.com/watch?v=Cwq3AFyV044
Available streams: 144p (worst), 240p, 360p, 480p, 720p, 1080p (best)

$ streamlink https://www.youtube.com/ABCNews
[cli][info] Found matching plugin youtube for URL https://www.youtube.com/ABCNews
Available streams: 144p (worst), 240p, 360p, 480p, 720p (best)

$ streamlink https://www.youtube.com/@ABCNews
[cli][info] Found matching plugin youtube for URL https://www.youtube.com/@ABCNews
Available streams: 144p (worst), 240p, 360p, 480p, 720p (best)

$ streamlink https://www.youtube.com/ABCNews/live
[cli][info] Found matching plugin youtube for URL https://www.youtube.com/ABCNews/live
Available streams: 144p (worst), 240p, 360p, 480p, 720p (best)

$ streamlink https://www.youtube.com/@ABCNews/live
[cli][info] Found matching plugin youtube for URL https://www.youtube.com/@ABCNews/live
Available streams: 144p (worst), 240p, 360p, 480p, 720p (best)

@bastimeyer bastimeyer added the plugin issue A Plugin does not work correctly label Aug 20, 2024
@bastimeyer bastimeyer force-pushed the plugins/youtube/check-4xx-http-responses branch from 7918846 to ad20b63 Compare August 20, 2024 18:16
@bastimeyer bastimeyer merged commit e93ae1a into streamlink:master Aug 20, 2024
18 checks passed
@bastimeyer bastimeyer deleted the plugins/youtube/check-4xx-http-responses branch August 20, 2024 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
plugin issue A Plugin does not work correctly
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@bastimeyer