Skip to content

Keyed handlers #1959

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Keyed handlers #1959

wants to merge 7 commits into from

Conversation

fuzzypixelz
Copy link
Member

No description provided.

@github-actions GitHub Actions
Copy link

PR missing one of the required labels: {'breaking-change', 'new feature', 'dependencies', 'documentation', 'bug', 'enhancement', 'internal'}

@fuzzypixelz fuzzypixelz added the internal Changes not included in the changelog label May 20, 2025
@evshary
Copy link
Contributor

evshary commented May 21, 2025

@fuzzypixelz I've already resolved the conflict in the branch from ZettaScaleLabs. Perhaps you can use that one directly
main...ZettaScaleLabs:zenoh:dev/keyed_handlers

@fuzzypixelz fuzzypixelz marked this pull request as ready for review May 21, 2025 07:57
@codecov Codecov
Copy link

codecov bot commented May 21, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 363 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@63a6e33). Learn more about missing BASE report.
Report is 5 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
zenoh/src/net/runtime/adminspace.rs 0.00% 321 Missing ⚠️
commons/zenoh-util/src/handler.rs 0.00% 36 Missing ⚠️
zenoh/src/api/queryable.rs 0.00% 3 Missing ⚠️
zenoh/src/api/sample.rs 0.00% 3 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1959   +/-   ##
=======================================
  Coverage        ?   70.80%           
=======================================
  Files           ?      365           
  Lines           ?    61551           
  Branches        ?        0           
=======================================
  Hits            ?    43581           
  Misses          ?    17970           
  Partials        ?        0

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

evshary
evshary approved these changes May 21, 2025
View reviewed changes
Copy link
Contributor

@evshary evshary left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if we should increase the test coverage, but it looks good to me anyway.
btw, the CI failure is due to out of space

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evshary evshary evshary approved these changes

Assignees
No one assigned
Labels
internal Changes not included in the changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fuzzypixelz @evshary @OlivierHecart