-
Notifications
You must be signed in to change notification settings - Fork 195
Keyed handlers #1959
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Keyed handlers #1959
Conversation
Signed-off-by: ChenYing Kuo <evshary@gmail.com>
PR missing one of the required labels: {'breaking-change', 'new feature', 'dependencies', 'documentation', 'bug', 'enhancement', 'internal'} |
@fuzzypixelz I've already resolved the conflict in the branch from ZettaScaleLabs. Perhaps you can use that one directly |
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #1959 +/- ##
=======================================
Coverage ? 70.80%
=======================================
Files ? 365
Lines ? 61551
Branches ? 0
=======================================
Hits ? 43581
Misses ? 17970
Partials ? 0 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if we should increase the test coverage, but it looks good to me anyway.
btw, the CI failure is due to out of space
No description provided.