Combobox role now works with button element #38535
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Content:Accessibility
|
hi @scottaohara - some changes here if you want to have a look 👀 Let us know if you need someone else to review instead. Thanks! |
|
This pull request has merge conflicts that must be resolved before it can be merged. |
…le/index.md Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…le/index.md Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
|
Preview URLs (comment last updated: 2025-07-16 10:37:58) |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
files/en-us/web/accessibility/aria/reference/roles/combobox_role/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/accessibility/aria/reference/roles/combobox_role/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/accessibility/aria/reference/roles/combobox_role/index.md
Outdated
Show resolved
Hide resolved
github-actions
bot
added
size/s
bsmth
reviewed
Jul 10, 2025
files/en-us/web/accessibility/aria/reference/roles/combobox_role/index.md
Outdated
Show resolved
Hide resolved
bsmth
reviewed
Jul 10, 2025
files/en-us/web/accessibility/aria/reference/roles/combobox_role/index.md
Outdated
Show resolved
Hide resolved
bsmth
reviewed
Jul 10, 2025
There was a problem hiding this comment.
I've some comments for you to have a look at, but this looks really good from my side. @scottaohara do you want to have a look through to check that everything's okay?
bsmth
approved these changes
Jul 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update combobox role docs to clarify input/button usage and improve keyboard interaction details. Fixes #36436