Update example in CSS sibling-count() function
#40830
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Content:CSS
|
Preview URLs (comment last updated: 2025-08-22 14:20:49) |
Josh-Cena
requested changes
Aug 21, 2025
|
I've reverted the description to the original description I use in my initial PR (#40120), based on the spec description. @Josh-Cena tell me if you approve this change. |
Josh-Cena
force-pushed
the
sibling-count-example
branch
from
226545e to
a15a462
Compare
Josh-Cena
approved these changes
Aug 22, 2025
There was a problem hiding this comment.
Thank you for the fix! The spec uses language like "direct children of the parent", which is slightly less straightforward, and your modification still suggests "direct children of the element" which is incorrect, so I'm opting for the more straightforward (but maybe less precise) wording "siblings including itself".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix bad example in CSS
sibling-count()function.Related issues and pull requests
Fixes #40755
Related #40120