Skip to content

Commit dcae8af

Browse files
authored
Update GHA workflows to use current Ubuntu and tools versions (#106)
1 parent d91e8b5 commit dcae8af

File tree

10 files changed

+11
-17
lines changed

10 files changed

+11
-17
lines changed

.github/workflows/dependencies.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,12 +7,12 @@ on:
77
pull_request:
88

99
env:
10-
PHP_VERSION: 7.4
10+
PHP_VERSION: 8.1
1111

1212
jobs:
1313
composer-require-checker:
1414
name: Check missing composer requirements
15-
runs-on: ubuntu-20.04
15+
runs-on: ubuntu-22.04
1616
steps:
1717
- name: Configure PHP version
1818
uses: shivammathur/setup-php@v2
@@ -32,4 +32,4 @@ jobs:
3232
composer update --no-interaction --no-scripts --no-progress
3333
composer show
3434
- name: ComposerRequireChecker
35-
uses: docker://webfactory/composer-require-checker:3.2.0
35+
uses: docker://ghcr.io/webfactory/composer-require-checker:4.8.0

.github/workflows/fix-cs-php.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ name: Coding Standards
99
jobs:
1010
open-pr-for-cs-violations:
1111
name: PHP-CS-Fixer
12-
runs-on: ubuntu-20.04
12+
runs-on: ubuntu-22.04
1313
if: github.actor != 'dependabot[bot]'
1414
steps:
1515
- name: Checkout code
@@ -18,7 +18,7 @@ jobs:
1818
ref: ${{ github.head_ref }}
1919

2020
- name: Run PHP-CS-Fixer
21-
uses: docker://oskarstark/php-cs-fixer-ga:3.11.0
21+
uses: docker://oskarstark/php-cs-fixer-ga:3.26.0
2222

2323
- name: Commit and push back changes
2424
uses: stefanzweifel/git-auto-commit-action@v4

.github/workflows/php-version-compatibility.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ on:
99
jobs:
1010
compat-check:
1111
name: Check dependency compatibility
12-
runs-on: ubuntu-20.04
12+
runs-on: ubuntu-22.04
1313
strategy:
1414
fail-fast: false
1515
matrix:

.github/workflows/release.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ name: Build .phar on release
66

77
jobs:
88
build_phar:
9-
runs-on: ubuntu-20.04
9+
runs-on: ubuntu-22.04
1010
steps:
1111
- name: Configure PHP version
1212
uses: shivammathur/setup-php@v2

.github/workflows/tests.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ on:
88

99
jobs:
1010
PHPUnit:
11-
runs-on: ubuntu-20.04
11+
runs-on: ubuntu-22.04
1212
strategy:
1313
fail-fast: false
1414
matrix:

src/Webfactory/Slimdump/Config/Column.php

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -46,9 +46,6 @@ public function getSelector()
4646
return $this->selector;
4747
}
4848

49-
/**
50-
* @return mixed
51-
*/
5249
public function getDump()
5350
{
5451
return $this->dump;

src/Webfactory/Slimdump/Config/Config.php

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -49,8 +49,6 @@ public function findTable($tableName)
4949

5050
/**
5151
* @param string $needle
52-
*
53-
* @return mixed
5452
*/
5553
public static function findBySelector(array $haystack, $needle)
5654
{

src/Webfactory/Slimdump/Config/FakerReplacer.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ public function __construct()
3939
*/
4040
public static function isFakerColumn($replacement)
4141
{
42-
return 0 === strpos($replacement, self::PREFIX);
42+
return str_starts_with($replacement, self::PREFIX);
4343
}
4444

4545
/**
@@ -53,7 +53,7 @@ public function generateReplacement($replacementId)
5353
{
5454
$replacementMethodName = str_replace(self::PREFIX, '', $replacementId);
5555

56-
if (false !== strpos($replacementMethodName, '->')) {
56+
if (str_contains($replacementMethodName, '->')) {
5757
[$modifierName, $replacementMethodName] = explode('->', $replacementMethodName);
5858

5959
$this->validateReplacementConfiguredModifier($modifierName, $replacementMethodName);

src/Webfactory/Slimdump/Database/CsvOutputFormatDriver.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ class CsvOutputFormatDriver implements OutputFormatDriverInterface
2222
/**
2323
* @var ?resource
2424
*/
25-
private $outputFile = null;
25+
private $outputFile;
2626

2727
/**
2828
* @var bool

test/Webfactory/Slimdump/Config/TableTest.php

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -138,7 +138,6 @@ public function testDumpTriggerDefaultSetting()
138138
* @dataProvider dumpTriggerAttributeValues
139139
*
140140
* @param string $value
141-
* @param $expected
142141
*
143142
* @throws mixed InvalidDumpTypeException
144143
*/

0 commit comments

Comments
 (0)