Skip to content

Optimize reading nodes directly from DB while repairing segments #7502

Open
@mniewrzal

Description

@mniewrzal

I just realized that we are still reading nodes metadata for each segment we wanted to repair. Some time ago w added caching for reading nodes at the beginning of repair process but we missed that one place. It's still generating traffic from Spanner to repair workers that we need to optimize.

Order CreateGetRepairOrderLimits method is still using GetOnlineNodesForAuditRepair which is reading nodes directly form DB. We should be able to get rid of this direct DB call by using cache or maybe it would be possible to reorganize code to remove it completely.

Acceptance Criteria:

  • review repair worker code (segments.go) and find a way to get rid of GetOnlineNodesForAuditRepair from CreateGetRepairOrderLimits
  • implement solution

Metadata

Metadata

Assignees

Type

Projects

Status

In Progress

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions