Skip to content

docs(html): Clarify default step base is 0 (1970-01-01) for date inputs #40365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 20, 2025
Merged

docs(html): Clarify default step base is 0 (1970-01-01) for date inputs #40365

merged 5 commits into from
Jul 20, 2025

Conversation

Shrinivassab
Copy link
Contributor

@Shrinivassab Shrinivassab commented Jul 15, 2025 •
edited
Loading

Description

Updates the input's documentation to explicitly state that the default step. (when neither min nor value is provided )

Motivation

Additional details

Related issues and pull requests

#40285

@Shrinivassab Shrinivassab requested a review from a team as a code owner July 15, 2025 03:41
@Shrinivassab Shrinivassab requested review from estelle and removed request for a team July 15, 2025 03:41
@github-actions github-actions bot added Content:HTML Hypertext Markup Language docs size/xs [PR only] 0-5 LoC changed labels Jul 15, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 15, 2025 •
edited
Loading

Preview URLs (9 pages)

(comment last updated: 2025-07-20 13:14:27)

Josh-Cena
Josh-Cena requested changes Jul 15, 2025
View reviewed changes
Copy link
Member

@Josh-Cena Josh-Cena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also check all other input types and propagate this same wording?

@Shrinivassab @Josh-Cena
Update files/en-us/web/html/reference/elements/input/date/index.md
2481e66 
Co-authored-by: Joshua Chen <sidachen2003@gmail.com>
@Shrinivassab
Copy link
Contributor Author

Sure. will check and update with similar wording.

estelle
estelle approved these changes Jul 16, 2025
View reviewed changes
Copy link
Member

@estelle estelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🎉

@github-actions github-actions bot added size/s [PR only] 6-50 LoC changed and removed size/xs [PR only] 0-5 LoC changed labels Jul 20, 2025
@github-actions github-actions bot added size/m [PR only] 51-500 LoC changed and removed size/s [PR only] 6-50 LoC changed labels Jul 20, 2025
Josh-Cena
Josh-Cena approved these changes Jul 20, 2025
View reviewed changes
Copy link
Member

@Josh-Cena Josh-Cena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you! I just reordered the paragraphs a bit to make it less repetitive.

@Josh-Cena Josh-Cena merged commit 1385610 into mdn:main Jul 20, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@estelle estelle estelle approved these changes

@Josh-Cena Josh-Cena Josh-Cena approved these changes

Assignees
No one assigned
Labels
Content:HTML Hypertext Markup Language docs size/m [PR only] 51-500 LoC changed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Shrinivassab @estelle @Josh-Cena