Skip to content

Modernize remaining JS #40398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 18, 2025
Merged

Modernize remaining JS #40398

merged 1 commit into from
Jul 18, 2025

Conversation

Josh-Cena
Copy link
Member

Make the code syntax consistent with our guidelines.

@Josh-Cena Josh-Cena requested review from a team as code owners July 17, 2025 05:25
@Josh-Cena Josh-Cena requested review from wbamberg and dotproto and removed request for a team July 17, 2025 05:25
@github-actions github-actions bot added Content:WebExt WebExtensions docs Content:WebAPI Web API docs labels Jul 17, 2025
@Josh-Cena Josh-Cena requested a review from rebloor July 17, 2025 05:25
@github-actions github-actions bot added the size/m [PR only] 51-500 LoC changed label Jul 17, 2025
@github-actions GitHub Actions
Copy link
Contributor

Preview URLs

Flaws (3)

Note! 3 documents with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Web/API/Web_components/Using_custom_elements
Title: Using custom elements
Flaw count: 3

  • macros:
    • Macro produces link /en-US/docs/Web/Web_Components/Using_custom_elements which is a redirect
    • Macro produces link /en-US/docs/Web/Web_Components/Using_shadow_DOM which is a redirect
    • Macro produces link /en-US/docs/Web/Web_Components/Using_templates_and_slots which is a redirect

dotproto
dotproto approved these changes Jul 18, 2025
View reviewed changes
Copy link
Collaborator

@dotproto dotproto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Josh-Cena Josh-Cena merged commit 7348ad4 into mdn:main Jul 18, 2025
7 checks passed
@Josh-Cena Josh-Cena deleted the modern-js branch July 18, 2025 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dotproto dotproto dotproto approved these changes

@wbamberg wbamberg Awaiting requested review from wbamberg wbamberg is a code owner automatically assigned from mdn/yari-content-web-api

@rebloor rebloor Awaiting requested review from rebloor

Assignees
No one assigned
Labels
Content:WebAPI Web API docs Content:WebExt WebExtensions docs size/m [PR only] 51-500 LoC changed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Josh-Cena @dotproto