Skip to content

Fix(ko): update /performance/guides folder structure, fix missing sidebar issue #26915

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Fix(ko): update /performance/guides folder structure, fix missing sidebar issue #26915

wants to merge 3 commits into from

Conversation

C17AN
Copy link
Contributor

@C17AN C17AN commented Apr 21, 2025

Description

  1. Fixes missing sidebar of Korean document. (Link)
image image
  1. Fix some Korean translation files are not properly positioned.
  • AS-IS : /performance/../index.md
  • TO-BE : /performance/guide/../index.md

Additional details

Currently, the English original document appears even when accessing the /ko/docs/Web/Performance path, but once the folder structure issue is fixed, the Korean translated document will be displayed correctly.

  • AS-IS
image
  • TO-BE
image

Related issues and pull requests

@C17AN C17AN requested a review from a team as a code owner April 21, 2025 12:15
@C17AN C17AN requested review from sunhpark42 and removed request for a team April 21, 2025 12:15
@github-actions github-actions bot added the l10n-ko Issues related to Korean content. label Apr 21, 2025
github-actions[bot]
github-actions bot reviewed Apr 21, 2025
View reviewed changes
files/ko/web/performance/guides/critical_rendering_path/index.md Outdated
@@ -1,10 +1,11 @@
---
title: 중요 렌더링 경로
slug: Web/Performance/Critical_rendering_path
sidebar: performancesidebar
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[mdn-linter] reported by reviewdog 🐶

Suggested change
sidebar: performancesidebar

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 21, 2025 •
edited
Loading

Preview URLs (24 pages)
Flaws (26)

Note! 17 documents with no flaws that don't need to be listed. 🎉

URL: /ko/docs/Learn_web_development/Extensions/Performance/Measuring_performance
Title: 웹 성능 측정하기
Flaw count: 5

  • broken_links:
    • /ko/docs/Learn/Getting_started_with_the_web is a redirect
  • macros:
    • Can't resolve /ko/docs/Learn/Performance/Perceived_performance
    • Can't resolve /ko/docs/Learn/Performance/Perceived_performance
  • unknown:
    • page(Doc) not found /ko/docs/Learn/Performance/Perceived_performance
    • page(Doc) not found /ko/docs/Learn/Performance/Perceived_performance

URL: /ko/docs/Learn_web_development/Extensions/Performance/Multimedia
Title: 멀티미디어: 이미지
Flaw count: 7

  • broken_links:
    • /ko/docs/Learn/Getting_started_with_the_web is a redirect
  • macros:
    • Macro produces link /ko/docs/Learn/Performance/measuring_performance which is a redirect
    • Macro produces link /ko/docs/Learn/Performance which is a redirect
    • Macro produces link /ko/docs/Learn/Performance/video which is a redirect
    • Macro produces link /ko/docs/Learn/Performance/measuring_performance which is a redirect
    • Macro produces link /ko/docs/Learn/Performance which is a redirect
    • and 1 more flaws omitted

URL: /ko/docs/Learn_web_development/Extensions/Performance/Web_Performance_Basics
Title: 웹 성능 리소스
Flaw count: 2

  • macros:
    • Can't resolve /ko/docs/Learn/Performance/business_case_for_performance
  • unknown:
    • page(Doc) not found /ko/docs/Learn/Performance/business_case_for_performance

URL: /ko/docs/Learn_web_development/Extensions/Performance/why_web_performance
Title: 웹 성능이 중요한 "이유"
Flaw count: 7

  • broken_links:
    • /ko/docs/Learn/Getting_started_with_the_web is a redirect
  • macros:
    • Macro produces link /ko/docs/Learn/Performance which is a redirect
    • Can't resolve /ko/docs/Learn/Performance/What_is_web_performance
    • Macro produces link /ko/docs/Learn/Performance which is a redirect
    • Can't resolve /ko/docs/Learn/Performance/What_is_web_performance
  • unknown:
    • page(Doc) not found /ko/docs/Learn/Performance/What_is_web_performance
    • page(Doc) not found /ko/docs/Learn/Performance/What_is_web_performance

URL: /ko/docs/Web/Performance
Title: 웹 성능
Flaw count: 3

  • macros:
    • Macro produces link /ko/docs/Glossary/Client_hints which is a redirect
    • Macro produces link /ko/docs/Glossary/First_interactive which is a redirect
    • Can't resolve /ko/docs/Glossary/Round_Trip_Time_(RTT)

URL: /ko/docs/Web/Performance/Guides/Lazy_loading
Title: 지연 로딩
Flaw count: 1

  • macros:
    • Can't resolve /ko/docs/Web/HTML/Element/iframe

URL: /ko/docs/Web/Performance/Guides/Understanding_latency
Title: 대기 시간(Latency) 이해하기
Flaw count: 1

  • macros:
    • Can't resolve /ko/docs/Glossary/DNS_lookup
External URLs (4)

URL: /ko/docs/Learn_web_development/Extensions/Performance/Multimedia
Title: 멀티미디어: 이미지

URL: /ko/docs/Web/Performance
Title: 웹 성능

(comment last updated: 2025-04-21 12:44:53)

@C17AN C17AN marked this pull request as draft April 21, 2025 12:48
@github-actions GitHub Actions
Copy link
Contributor

This pull request has merge conflicts that must be resolved before it can be merged.

@github-actions github-actions bot added the merge conflicts 🚧 This pull request has merge conflicts that must be resolved. label Apr 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@sunhpark42 sunhpark42 Awaiting requested review from sunhpark42 sunhpark42 is a code owner automatically assigned from mdn/yari-content-ko

Assignees
No one assigned
Labels
l10n-ko Issues related to Korean content. merge conflicts 🚧 This pull request has merge conflicts that must be resolved.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@C17AN