fix: various fixes when using yari in fred #13142
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
use "real" links to articles in collections import all screenshots used in plus overview page hide offline settings if FRED_FLAG is set
Bundle StatsHey there, this message comes from a github action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
View detailed bundle breakdownAdded
Removed No assets were removed Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
caugner
approved these changes
Jun 11, 2025
client/src/env.ts
Outdated
| @@ -135,3 +135,5 @@ export function survey_rates(surveyKey: string): { | |||
| export const OBSERVATORY_API_URL = | |||
| process.env.REACT_APP_OBSERVATORY_API_URL || | |||
| "https://observatory-api.mdn.allizom.net"; | |||
|
|
|||
| export const FRED_FLAG = JSON.parse(process.env.REACT_APP_FRED_FLAG || "false"); | |||
There was a problem hiding this comment.
Nit: Why not just FRED?
Suggested change
| export const FRED_FLAG = JSON.parse(process.env.REACT_APP_FRED_FLAG || "false"); | |
| export const FRED = JSON.parse(process.env.REACT_APP_FRED || "false"); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Problem
Various things from yari weren't working correctly in fred
Solution
use "real" links to articles in collections
import all screenshots used in plus overview page
hide offline settings if FRED_FLAG is set
How did you test this change?
yarn devyet to test these work in fred