chore(plus): upgrade to SubPlat 3.0 #13199
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
plus
Bundle StatsHey there, this message comes from a github action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
caugner
changed the title
caugner
reviewed
Jun 24, 2025
client/src/env.ts
Outdated
Comment on lines
65
to
71
| export const MDN_PLUS_SUBSCRIBE_URL_SP3_BASE = | ||
| process.env.REACT_APP_MDN_PLUS_SUBSCRIBE_URL_SP3_BASE; | ||
| export const MDN_PLUS_USE_SP3 = Boolean(MDN_PLUS_SUBSCRIBE_URL_SP3_BASE); | ||
| export const MDN_PLUS_SUBSCRIBE_5M_URL_SP3 = `${MDN_PLUS_SUBSCRIBE_URL_SP3_BASE}/${process.env.REACT_APP_MDN_PLUS_5M_SP3_ID}/monthly/landing`; | ||
| export const MDN_PLUS_SUBSCRIBE_5Y_URL_SP3 = `${MDN_PLUS_SUBSCRIBE_URL_SP3_BASE}/${process.env.REACT_APP_MDN_PLUS_5Y_SP3_ID}/yearly/landing`; | ||
| export const MDN_PLUS_SUBSCRIBE_10M_URL_SP3 = `${MDN_PLUS_SUBSCRIBE_URL_SP3_BASE}/${process.env.REACT_APP_MDN_PLUS_10M_SP3_ID}/monthly/landing`; | ||
| export const MDN_PLUS_SUBSCRIBE_10Y_URL_SP3 = `${MDN_PLUS_SUBSCRIBE_URL_SP3_BASE}/${process.env.REACT_APP_MDN_PLUS_10Y_SP3_ID}/yearly/landing`; |
There was a problem hiding this comment.
Nit: We want to document env variables in https://github.com/mdn/yari/blob/main/docs/envvars.md.
Comment on lines
+280
to
+281
| REACT_APP_MDN_PLUS_10M_SP3_ID: mdnsupporter10mstage | ||
| REACT_APP_MDN_PLUS_10Y_SP3_ID: mdnsupporter10ystage |
There was a problem hiding this comment.
Why are these called mdnsupporter here and mdnplus above (in prod)?
There was a problem hiding this comment.
This is not ours to question I think. I do not have yet access to the subplat backend. The prod identifiers are consistent though.
LeoMcA
approved these changes
Jun 24, 2025
| @@ -277,12 +290,16 @@ function getLocalizedPlans(countrySpecific: StripePlans): { | |||
| currency: countrySpecific.currency, | |||
| regular: { | |||
| ...PLUS_5.regular, | |||
| ctaLink: `${MDN_PLUS_SUBSCRIBE_BASE}?plan=${countrySpecific.plans["mdn_plus_5m"].id}`, | |||
| ctaLink: MDN_PLUS_USE_SP3 | |||
| ? MDN_PLUS_SUBSCRIBE_5M_URL_SP3 | |||
There was a problem hiding this comment.
Does SP3 no longer require us to pass the country specific plan in the url?
There was a problem hiding this comment.
The country is handled on their side now AFAIK
Co-authored-by: Leo McArdle <leo@mca.is>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Subscription Platform 3 rollout