fix(plus): fix use sp3 #13205
Merged
fix(plus): fix use sp3 #13205
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this got broken in 4256f47
Bundle StatsHey there, this message comes from a github action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
caugner
reviewed
Jun 24, 2025
| @@ -65,7 +65,7 @@ export const PLACEMENT_ENABLED = Boolean( | |||
| export const MDN_PLUS_SUBSCRIBE_URL_SP3_BASE = | |||
| process.env.REACT_APP_MDN_PLUS_SUBSCRIBE_URL_SP3_BASE; | |||
| export const MDN_PLUS_USE_SP3 = Boolean( | |||
| JSON.parse(process.env.REACT_APP_MDN_PLUS_USE_SP3 || "false") | |||
| JSON.parse(MDN_PLUS_SUBSCRIBE_URL_SP3_BASE || "false") | |||
There was a problem hiding this comment.
Nit: Leo's intent was to use a separate environment variable to switch to SP3, rather than deriving this from MDN_PLUS_SUBSCRIBE_URL_SP3_BASE.
So in that sense we should set REACT_APP_MDN_PLUS_USE_SP3=true in {prod,stage}-build instead.
There was a problem hiding this comment.
We can do this as a follow up. I just want to get this out.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
USE_SP3should be base onMDN_PLUS_SUBSCRIBE_URL_SP3_BASEthis got broken in 4256f47