-
Notifications
You must be signed in to change notification settings - Fork 536
chore(deps): replace got with fetch #13225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Bundle StatsHey there, this message comes from a github action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
3d98e32
to
ca1b50f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Self-approval, as the changes only affect no longer used and deprecated code.
Summary
Problem
got
is outdated and has security issues.Solution
Migrate to
fetch
.Note:
fetch
is still considered experimental in Node.js 20, so we need to ignore the corresponding warnings.Screenshots
Before
After
How did you test this change?
build
andkumascript
folder are no longer used in production.