Handled POSIX path to video directories in split_video_frames #192
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
capjamesg
requested changes
May 14, 2025
|
|
||
| if os.path.isdir(video_path): | ||
| # Process all video files in the directory | ||
| video_files = [ |
There was a problem hiding this comment.
Can we still use the supervision function to get video paths?
video_paths = sv.list_files_with_extensions(
directory=video_path, extensions=["mov", "mp4", "MOV", "MP4"]
)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request refactors the
split_video_framesfunction inautodistill/helpers.pyto enhance its functionality and improve code clarity. The function now supports processing both individual video files and directories containing multiple video files, while also replacing the use of external utilities with direct OpenCV operations for frame extraction.Enhancements to
split_video_frames:.mp4,.mov,.avi,.mkv) in the directory.sv.list_files_with_extensionsandsv.get_video_frames_generatorwith OpenCV'sVideoCapturefor frame extraction, providing more direct control over the process.Related Issue: #179