showAsData/ResourcePack ignores dependency loading order #2395
Description
Minecraft Version: 1.21.1, however through code analysis I have determined this is an issue for 1.20.4-1.21.7 (since #400)
NeoForge Version: 21.1.174, See comment above
Steps to Reproduce:
- Add a pack.mcmeta file to the root of mod resources, like this one:
{
"pack": {
"description": "a test pack.mcmeta",
"pack_format": 10
}
}- In the neoforge.mods.toml file set a dependency on neoforge with load order set to AFTER, like so:
[[dependencies."${modid}"]]
modId="neoforge"
type="required"
versionRange="[21.1.174,)"
ordering="AFTER"
side="BOTH"- Also in the neoforge.mods.toml file set
showAsDataPackto true:
(note this is a file property, not a mod property, so must be placed above[[mods]])
showAsDataPack=true- Start the game and open the create world screen, then go to the More tab and select Data Packs
- Note that the mod datapack is below the Mod Data grouped pack despite being told to explicitly load after neo.
Description of issue:
In ResourcePackLoader all packs that need to be separate are added to the pack consumer:
before the grouped pack is added:
which causes this issue.
Solving this to respect mod loader order is very difficult, as you can easily construct a situation where the grouped pack would need to be split to properly order mod sources.
An easier solution would be to make these separate packs always load after the rest of the mod resources, as that is the more common option for people to want to do, or change the boolean option to an enum option of something like
GROUPED, ABOVE, BELOW that determines where it goes.