Skip to content

fix: deduplicate variable names in no-loop-func error messages #19595

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 3, 2025

Conversation

snitin315
Copy link
Contributor

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[x] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)

Fix #19586

Is there anything you'd like reviewers to focus on?

No

@snitin315 snitin315 requested a review from a team as a code owner April 2, 2025 16:41
@github-project-automation github-project-automation bot moved this to Needs Triage in Triage Apr 2, 2025
@eslint-github-bot eslint-github-bot bot added the bug ESLint is working incorrectly label Apr 2, 2025
@github-actions github-actions bot added the rule Relates to ESLint's core rules label Apr 2, 2025
Copy link

netlify bot commented Apr 2, 2025

Deploy Preview for docs-eslint canceled.

Name Link
🔨 Latest commit f428457
🔍 Latest deploy log https://app.netlify.com/sites/docs-eslint/deploys/67edda5e7d3d43000856f2a0

@mdjermanovic
Copy link
Member

Looks like there's a formatting error.

@snitin315
Copy link
Contributor Author

Looks like there's a formatting error.

Fixed

@mdjermanovic mdjermanovic added the accepted There is consensus among the team that this change meets the criteria for inclusion label Apr 3, 2025
Copy link
Member

@mdjermanovic mdjermanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@mdjermanovic mdjermanovic merged commit b23d1c5 into main Apr 3, 2025
31 checks passed
@mdjermanovic mdjermanovic deleted the fix/no-loop-func-error-msg branch April 3, 2025 07:32
@github-project-automation github-project-automation bot moved this from Needs Triage to Complete in Triage Apr 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion bug ESLint is working incorrectly rule Relates to ESLint's core rules
Projects
Status: Complete
Development

Successfully merging this pull request may close these issues.

Bug: fix error message in no-loop-func
2 participants