Type safe parameters for math functions.

leozide · leozide · commit f3f76d2ffe28 · 2025-05-24T14:16:53.000-07:00
diff --git a/common/lc_math.h b/common/lc_math.h
@@ -1589,7 +1589,7 @@ inline lcVector3 lcQuaternionMul(const lcVector3& a, const lcVector4& b)
 }
 
 // Convert world coordinates to screen coordinates.
-inline lcVector3 lcProjectPoint(const lcVector3& Point, const lcMatrix44& ModelView, const lcMatrix44& Projection, const int Viewport[4])
+inline lcVector3 lcProjectPoint(const lcVector3& Point, const lcMatrix44& ModelView, const lcMatrix44& Projection, const int (&Viewport)[4])
 {
 	lcVector4 Tmp;
 
@@ -1603,7 +1603,7 @@ inline lcVector3 lcProjectPoint(const lcVector3& Point, const lcMatrix44& ModelV
 	return lcVector3(Viewport[0] + (1 + Tmp[0]) * Viewport[2] / 2, Viewport[1] + (1 + Tmp[1]) * Viewport[3] / 2, (1 + Tmp[2]) / 2);
 }
 
-inline lcVector3 lcUnprojectPoint(const lcVector3& Point, const lcMatrix44& ModelView, const lcMatrix44& Projection, const int Viewport[4])
+inline lcVector3 lcUnprojectPoint(const lcVector3& Point, const lcMatrix44& ModelView, const lcMatrix44& Projection, const int (&Viewport)[4])
 {
 	// Calculate the screen to model transform.
 	const lcMatrix44 Transform = lcMatrix44Inverse(lcMul(ModelView, Projection));
@@ -1624,7 +1624,7 @@ inline lcVector3 lcUnprojectPoint(const lcVector3& Point, const lcMatrix44& Mode
 	return lcVector3(Tmp[0], Tmp[1], Tmp[2]);
 }
 
-inline void lcUnprojectPoints(lcVector3* Points, int NumPoints, const lcMatrix44& ModelView, const lcMatrix44& Projection, const int Viewport[4])
+inline void lcUnprojectPoints(lcVector3* Points, int NumPoints, const lcMatrix44& ModelView, const lcMatrix44& Projection, const int (&Viewport)[4])
 {
 	// Calculate the screen to model transform.
 	const lcMatrix44 Transform = lcMatrix44Inverse(lcMul(ModelView, Projection));
@@ -1648,7 +1648,7 @@ inline void lcUnprojectPoints(lcVector3* Points, int NumPoints, const lcMatrix44
 	}
 }
 
-inline void lcGetFrustumPlanes(const lcMatrix44& WorldView, const lcMatrix44& Projection, lcVector4 Planes[6])
+inline void lcGetFrustumPlanes(const lcMatrix44& WorldView, const lcMatrix44& Projection, lcVector4 (&Planes)[6])
 {
 	lcMatrix44 WorldProj = lcMul(WorldView, Projection);
 
@@ -1878,7 +1878,7 @@ inline void lcPolygonPlaneClip(lcVector3* InPoints, int NumInPoints, lcVector3*
 }
 
 // Return true if a polygon intersects a set of planes.
-inline bool lcTriangleIntersectsPlanes(const lcVector3& p1, const lcVector3& p2, const lcVector3& p3, const lcVector4 Planes[6])
+inline bool lcTriangleIntersectsPlanes(const lcVector3& p1, const lcVector3& p2, const lcVector3& p3, const lcVector4 (&Planes)[6])
 {
 	constexpr int NumPlanes = 6;
 	const lcVector3 Points[3] = { p1, p2, p3 };
@@ -2212,7 +2212,7 @@ inline float lcRayPointDistance(const lcVector3& Point, const lcVector3& Start,
 }
 
 // Returns true if the axis aligned box intersects the volume defined by planes.
-inline bool lcBoundingBoxIntersectsVolume(const lcVector3& Min, const lcVector3& Max, const lcVector4 Planes[6])
+inline bool lcBoundingBoxIntersectsVolume(const lcVector3& Min, const lcVector3& Max, const lcVector4 (&Planes)[6])
 {
 	constexpr int NumPlanes = 6;
 	lcVector3 Points[8] =
@@ -2287,7 +2287,7 @@ struct lcBoundingBox
 	lcVector3 Max;
 };
 
-inline void lcGetBoxCorners(const lcVector3& Min, const lcVector3& Max, lcVector3 Points[8])
+inline void lcGetBoxCorners(const lcVector3& Min, const lcVector3& Max, lcVector3 (&Points)[8])
 {
 	Points[0] = lcVector3(Max.x, Max.y, Min.z);
 	Points[1] = lcVector3(Min.x, Max.y, Min.z);
@@ -2299,7 +2299,7 @@ inline void lcGetBoxCorners(const lcVector3& Min, const lcVector3& Max, lcVector
 	Points[7] = lcVector3(Min.x, Max.y, Max.z);
 }
 
-inline void lcGetBoxCorners(const lcBoundingBox& BoundingBox, lcVector3 Points[8])
+inline void lcGetBoxCorners(const lcBoundingBox& BoundingBox, lcVector3 (&Points)[8])
 {
 	lcGetBoxCorners(BoundingBox.Min, BoundingBox.Max, Points);
 }

Original file line number	Diff line number	Diff line change
`@@ -1589,7 +1589,7 @@ inline lcVector3 lcQuaternionMul(const lcVector3& a, const lcVector4& b)`
`1589`	`1589`	`}`
`1590`	`1590`
`1591`	`1591`	`// Convert world coordinates to screen coordinates.`
`1592`		`-inline lcVector3 lcProjectPoint(const lcVector3& Point, const lcMatrix44& ModelView, const lcMatrix44& Projection, const int Viewport[4])`
	`1592`	`+inline lcVector3 lcProjectPoint(const lcVector3& Point, const lcMatrix44& ModelView, const lcMatrix44& Projection, const int (&Viewport)[4])`
`1593`	`1593`	`{`
`1594`	`1594`	`lcVector4 Tmp;`
`1595`	`1595`
`@@ -1603,7 +1603,7 @@ inline lcVector3 lcProjectPoint(const lcVector3& Point, const lcMatrix44& ModelV`
`1603`	`1603`	`return lcVector3(Viewport[0] + (1 + Tmp[0]) * Viewport[2] / 2, Viewport[1] + (1 + Tmp[1]) * Viewport[3] / 2, (1 + Tmp[2]) / 2);`
`1604`	`1604`	`}`
`1605`	`1605`
`1606`		`-inline lcVector3 lcUnprojectPoint(const lcVector3& Point, const lcMatrix44& ModelView, const lcMatrix44& Projection, const int Viewport[4])`
	`1606`	`+inline lcVector3 lcUnprojectPoint(const lcVector3& Point, const lcMatrix44& ModelView, const lcMatrix44& Projection, const int (&Viewport)[4])`
`1607`	`1607`	`{`
`1608`	`1608`	`// Calculate the screen to model transform.`
`1609`	`1609`	`const lcMatrix44 Transform = lcMatrix44Inverse(lcMul(ModelView, Projection));`
`@@ -1624,7 +1624,7 @@ inline lcVector3 lcUnprojectPoint(const lcVector3& Point, const lcMatrix44& Mode`
`1624`	`1624`	`return lcVector3(Tmp[0], Tmp[1], Tmp[2]);`
`1625`	`1625`	`}`
`1626`	`1626`
`1627`		`-inline void lcUnprojectPoints(lcVector3* Points, int NumPoints, const lcMatrix44& ModelView, const lcMatrix44& Projection, const int Viewport[4])`
	`1627`	`+inline void lcUnprojectPoints(lcVector3* Points, int NumPoints, const lcMatrix44& ModelView, const lcMatrix44& Projection, const int (&Viewport)[4])`
`1628`	`1628`	`{`
`1629`	`1629`	`// Calculate the screen to model transform.`
`1630`	`1630`	`const lcMatrix44 Transform = lcMatrix44Inverse(lcMul(ModelView, Projection));`
`@@ -1648,7 +1648,7 @@ inline void lcUnprojectPoints(lcVector3* Points, int NumPoints, const lcMatrix44`
`1648`	`1648`	`}`
`1649`	`1649`	`}`
`1650`	`1650`
`1651`		`-inline void lcGetFrustumPlanes(const lcMatrix44& WorldView, const lcMatrix44& Projection, lcVector4 Planes[6])`
	`1651`	`+inline void lcGetFrustumPlanes(const lcMatrix44& WorldView, const lcMatrix44& Projection, lcVector4 (&Planes)[6])`
`1652`	`1652`	`{`
`1653`	`1653`	`lcMatrix44 WorldProj = lcMul(WorldView, Projection);`
`1654`	`1654`
`@@ -1878,7 +1878,7 @@ inline void lcPolygonPlaneClip(lcVector3* InPoints, int NumInPoints, lcVector3*`
`1878`	`1878`	`}`
`1879`	`1879`
`1880`	`1880`	`// Return true if a polygon intersects a set of planes.`
`1881`		`-inline bool lcTriangleIntersectsPlanes(const lcVector3& p1, const lcVector3& p2, const lcVector3& p3, const lcVector4 Planes[6])`
	`1881`	`+inline bool lcTriangleIntersectsPlanes(const lcVector3& p1, const lcVector3& p2, const lcVector3& p3, const lcVector4 (&Planes)[6])`
`1882`	`1882`	`{`
`1883`	`1883`	`constexpr int NumPlanes = 6;`
`1884`	`1884`	`const lcVector3 Points[3] = { p1, p2, p3 };`
`@@ -2212,7 +2212,7 @@ inline float lcRayPointDistance(const lcVector3& Point, const lcVector3& Start,`
`2212`	`2212`	`}`
`2213`	`2213`
`2214`	`2214`	`// Returns true if the axis aligned box intersects the volume defined by planes.`
`2215`		`-inline bool lcBoundingBoxIntersectsVolume(const lcVector3& Min, const lcVector3& Max, const lcVector4 Planes[6])`
	`2215`	`+inline bool lcBoundingBoxIntersectsVolume(const lcVector3& Min, const lcVector3& Max, const lcVector4 (&Planes)[6])`
`2216`	`2216`	`{`
`2217`	`2217`	`constexpr int NumPlanes = 6;`
`2218`	`2218`	`lcVector3 Points[8] =`
`@@ -2287,7 +2287,7 @@ struct lcBoundingBox`
`2287`	`2287`	`lcVector3 Max;`
`2288`	`2288`	`};`
`2289`	`2289`
`2290`		`-inline void lcGetBoxCorners(const lcVector3& Min, const lcVector3& Max, lcVector3 Points[8])`
	`2290`	`+inline void lcGetBoxCorners(const lcVector3& Min, const lcVector3& Max, lcVector3 (&Points)[8])`
`2291`	`2291`	`{`
`2292`	`2292`	`Points[0] = lcVector3(Max.x, Max.y, Min.z);`
`2293`	`2293`	`Points[1] = lcVector3(Min.x, Max.y, Min.z);`
`@@ -2299,7 +2299,7 @@ inline void lcGetBoxCorners(const lcVector3& Min, const lcVector3& Max, lcVector`
`2299`	`2299`	`Points[7] = lcVector3(Min.x, Max.y, Max.z);`
`2300`	`2300`	`}`
`2301`	`2301`
`2302`		`-inline void lcGetBoxCorners(const lcBoundingBox& BoundingBox, lcVector3 Points[8])`
	`2302`	`+inline void lcGetBoxCorners(const lcBoundingBox& BoundingBox, lcVector3 (&Points)[8])`
`2303`	`2303`	`{`
`2304`	`2304`	`lcGetBoxCorners(BoundingBox.Min, BoundingBox.Max, Points);`
`2305`	`2305`	`}`