Chaos Toolkit
Replies: 2 comments 7 replies
-
|
Can you share the experiment.json ? |
Beta Was this translation helpful? Give feedback.
1 reply
-
|
Here is my whole experiment.yml. |
Beta Was this translation helpful? Give feedback.
-
|
I am not sure if if r.status_code != expected_status:
raise FailedActivity(r.text)but it looks like this was removed years ago
The CTK syntax isn't strictly enforced, so you can add attributes to it that just don't get evaluated. I suspect that's what's happening with the Thats my initial stab in the dark. |
Beta Was this translation helpful? Give feedback.
6 replies
-
|
yeah sorry you are correct. but it was then removed in chaostoolkit/chaostoolkit-lib@73485bf#diff-dfb901a151082728ffae7149b8abb03423afdc265856844099c08c97d444a3bf
|
Beta Was this translation helpful? Give feedback.
-
|
I don't quite understand the reason "It is not the purpose of an activity to perform that check". And what about making the failure optional, like this: expected_status = provider.get("expected_status", None)
[...]
if expected_status != None and r.status_code != expected_status:
raise FailedActivity(r.text) |
Beta Was this translation helpful? Give feedback.
-
|
That's a valid and fair question. I cant speak for the design or reasoning as to why this was removed when it previously existed unfortunately. |
Beta Was this translation helpful? Give feedback.
-
|
Sounds good, thank you! |
Beta Was this translation helpful? Give feedback.
-
|
If you want to test or showcase this I have implemented a working solution. import logging
from typing import Any
import requests
import urllib3
from chaoslib import substitute
from chaoslib.exceptions import ActivityFailed, InvalidActivity
from chaoslib.types import Activity, Configuration, Secrets
__all__ = ["run_http_activity", "validate_http_activity"]
logger = logging.getLogger("chaostoolkit")
urllib3.disable_warnings(urllib3.exceptions.InsecureRequestWarning)
def run_http_activity(
activity: Activity, configuration: Configuration, secrets: Secrets
) -> Any:
"""
Run a HTTP activity.
A HTTP activity is a call to a HTTP endpoint and its result is returned as
the raw result of this activity.
Raises :exc:`ActivityFailed` when a timeout occurs for the request or when
the endpoint returns a status in the 400 or 500 ranges.
This should be considered as a private function.
"""
provider = activity["provider"]
url = substitute(provider["url"], configuration, secrets)
method = provider.get("method", "GET").upper()
headers = substitute(provider.get("headers", None), configuration, secrets)
timeout = substitute(provider.get("timeout", None), configuration, secrets)
arguments = provider.get("arguments", None)
verify_tls = provider.get("verify_tls", True)
max_retries = provider.get("max_retries", 0)
expected_status = provider.get("expected_status", None)
if arguments and (configuration or secrets):
arguments = substitute(arguments, configuration, secrets)
if isinstance(timeout, list):
timeout = tuple(timeout)
try:
s = requests.Session()
a = requests.adapters.HTTPAdapter(max_retries=max_retries)
s.mount("http://", a)
s.mount("https://", a)
if method == "GET":
r = s.get(
url,
params=arguments,
headers=headers,
timeout=timeout,
verify=verify_tls,
)
else:
if headers and headers.get("Content-Type") == "application/json":
r = s.request(
method,
url,
json=arguments,
headers=headers,
timeout=timeout,
verify=verify_tls,
)
else:
r = s.request(
method,
url,
data=arguments,
headers=headers,
timeout=timeout,
verify=verify_tls,
)
body = None
if r.headers.get("Content-Type") == "application/json":
body = r.json()
else:
body = r.text
if expected_status != None and r.status_code != expected_status:
raise ActivityFailed(f"status {r.status_code}")
# kind warning to the user that this HTTP call may be invalid
# but not during the hypothesis check because that could also be
# exactly what the user want. This warning is helpful during the
# method and rollbacks
if "tolerance" not in activity and r.status_code > 399:
logger.warning(
"This HTTP call returned a response with a HTTP status code "
"above 400. This may indicate some error and not "
"what you expected. Please have a look at the logs."
)
return {
"status": r.status_code,
"headers": dict(**r.headers),
"body": body,
}
except requests.exceptions.ConnectionError as cex:
raise ActivityFailed(f"failed to connect to {url}: {str(cex)}")
except requests.exceptions.Timeout:
raise ActivityFailed("activity took too long to complete")
def validate_http_activity(activity: Activity):
"""
Validate a HTTP activity.
A process activity requires:
* a `"url"` key which is the address to call
In addition, you can pass the followings:
* `"method"` which is the HTTP verb to use (default to `"GET"`)
* `"headers"` which must be a mapping of string to string
In all failing cases, raises :exc:`InvalidActivity`.
This should be considered as a private function.
"""
provider = activity["provider"]
url = provider.get("url")
if not url:
raise InvalidActivity("a HTTP activity must have a URL")
headers = provider.get("headers")
if headers and not isinstance(headers, dict):
raise InvalidActivity("a HTTP activities expect headers as a mapping") |
Beta Was this translation helpful? Give feedback.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
-
In my experiment I want to terminate a kubernetes pod and test the api responses of the app right after.
In the generated journal I can see that the http request had a status of 500, which does not match the expected_status of 200:
Why is it, that the status of the probe is still "succeeded", although the output status does not match the expected_status?
Is there a way to get the probe to "fail" when the expected_status is not matched?
Beta Was this translation helpful? Give feedback.
All reactions