Skip to content

Feat(Icon): add-child #7323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 10, 2025
Merged

Feat(Icon): add-child #7323

merged 5 commits into from
Mar 10, 2025

Conversation

ryannono
Copy link
Contributor

@ryannono ryannono commented Mar 6, 2025

Changes proposed in this pull request:

Add child icon

Reviewers should focus on:

  • Icon path
  • Json
  • Style

Screenshot

image

@changelog-app
Copy link

changelog-app bot commented Mar 6, 2025

Generate changelog in packages/icons/changelog/@unreleased

What do the change types mean?
  • feature: A new feature of the service.
  • improvement: An incremental improvement in the functionality or operation of the service.
  • fix: Remedies the incorrect behaviour of a component of the service in a backwards-compatible way.
  • break: Has the potential to break consumers of this service's API, inclusive of both Palantir services
    and external consumers of the service's API (e.g. customer-written software or integrations).
  • deprecation: Advertises the intention to remove service functionality without any change to the
    operation of the service itself.
  • manualTask: Requires the possibility of manual intervention (running a script, eyeballing configuration,
    performing database surgery, ...) at the time of upgrade for it to succeed.
  • migration: A fully automatic upgrade migration task with no engineer input required.

Note: only one type should be chosen.

How are new versions calculated?
  • ❗The break and manual task changelog types will result in a major release!
  • 🐛 The fix changelog type will result in a minor release in most cases, and a patch release version for patch branches. This behaviour is configurable in autorelease.
  • ✨ All others will result in a minor version release.

Type

  • Feature
  • Improvement
  • Fix
  • Break
  • Deprecation
  • Manual task
  • Migration

Description

Feat(Icon): add-child

Check the box to generate changelog(s)

  • Generate changelog entry

@svc-palantir-github
Copy link

Update icons.json

Build artifact links for this commit: documentation | landing | table | demo

This is an automated comment from the deploy-preview CircleCI job.

ggdouglas
ggdouglas previously approved these changes Mar 7, 2025
@policy-bot policy-bot bot dismissed ggdouglas’s stale review March 7, 2025 16:41

Invalidated by push of 26c398e

@svc-palantir-github
Copy link

Merge branch 'develop' into origin/rn/add-children

Build artifact links for this commit: documentation | landing | table | demo

This is an automated comment from the deploy-preview CircleCI job.

@svc-palantir-github
Copy link

remove extra line

Build artifact links for this commit: documentation | landing | table | demo

This is an automated comment from the deploy-preview CircleCI job.

@ryannono ryannono enabled auto-merge (squash) March 10, 2025 18:00
@ryannono ryannono merged commit 743aefb into develop Mar 10, 2025
13 of 15 checks passed
@ryannono ryannono deleted the origin/rn/add-children branch March 10, 2025 18:05
jscheiny pushed a commit that referenced this pull request Mar 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants