Skip to content

plugins.twitch: remove platform access token param #3220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

bastimeyer
Copy link
Member

This once again removes the platform=_ parameter from the stream access token request.

See #3210
As mentioned there, we need a better solution for this. Am happy to discuss this.


History of the parameter:

  1. Added in plugins.twitch: platform=_ in access_token request #2358
  2. Removed in plugins.twitch: fix API issue - 410 gone error #2692
  3. Added in plugins.twitch: platform=_ in access_token request #3173

@bastimeyer bastimeyer added the plugin enhancement A new feature for a working Plugin label Oct 3, 2020
@gravyboat
Copy link
Member

gravyboat commented Oct 3, 2020

@bastimeyer I'm not in favor of doing this. again. As you noted:

Any volunteers for this work? Because I am already annoyed.

I don't feel like doing more, it is extremely annoying.

Maybe a param with CLI output for when it catches an ad and we link to the documentation talking about how to use the param? We need a way to keep people out of our hair on this as much as possible, that's the real problem. The less configuration required the better.

@bastimeyer
Copy link
Member Author

Let's get this merged, so that we can have a nightly build tomorrow which includes this change and the new filtering.

How the ads workaround should get handled in the future can be discussed later. A note when an ad is playing for the first time with a link to a page with instructions on setting custom request parameters doesn't sound too bad though.

@back-to back-to merged commit 710787b into streamlink:master Oct 3, 2020
@bastimeyer bastimeyer deleted the plugins/twitch/access-token-platform-removal-2020-10-03 branch October 9, 2020 06:52
resiproxy pushed a commit to resiproxy/streamlink that referenced this pull request Nov 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plugin enhancement A new feature for a working Plugin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants