cli/edit: allow empty due dates in non-interactive mode #577
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fermino
changed the title
|
Does this not unconditionally unset the E.g.: I specify |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into the necessity to batch-edit a bunch of tasks to unset the due date, and in doing so found that there's no supported way to "unset" it without using the interactive mode.
This PR aims to fix that. The current fix is somewhat quick-n-dirty, and I think it would be better to dynamically detect if the field is allowed to be
Noneby using type annotations, but I'm just starting to dig into the codebase so I want to post it here first!Anyways, thanks for all the work in the project :)