stream.dash: add --dash-manifest-reload-attempts #5208
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bastimeyer
force-pushed
the
stream/dash/dash-manifest-reload-attempts
branch
from
868f9e2 to
924b6d5
Compare
gravyboat
reviewed
Feb 28, 2023
bastimeyer
force-pushed
the
stream/dash/dash-manifest-reload-attempts
branch
from
924b6d5 to
4341dce
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds
--dash-manifest-reload-attemptsand the respective session option with a default value of 3, similar to--hls-playlist-reload-attempts.HTTP requests of dynamic DASH stream manifests currently don't have a retry value set, so if a request fails due to a temporary connection/server issue, then no new segments can be queued. Failed requests still raise a
StreamErroron the worker thread, same as the HLS implementation, which needs to be fixed separately.