Skip to content

plugins.nicolive: fixed websocket-client and use websocket-client>=0.58.0 #3634

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 20, 2021
Merged

plugins.nicolive: fixed websocket-client and use websocket-client>=0.58.0 #3634

merged 2 commits into from
Mar 20, 2021

Conversation

back-to
Copy link
Collaborator

@back-to back-to commented Mar 20, 2021 

setup.py: require websocket-client>=0.58.0

Make sure all User use the same version where `callback(self, *args)` was changed.

plugins.nicolive: fixed websocket-client

closes #3631
closes #3633

back-to added 2 commits March 20, 2021 09:49
@back-to
setup.py: require websocket-client>=0.58.0
9e420c0 
Make sure all User use the same version where `callback(self, *args)` was changed.

Ref websocket-client/websocket-client#669
@back-to
plugins.nicolive: fixed websocket-client
11bf167
@back-to back-to added plugin issue A Plugin does not work correctly dependencies labels Mar 20, 2021
@back-to back-to changed the title Websocket plugins.nicolive: fixed websocket-client and use websocket-client>=0.58.0 Mar 20, 2021
@bastimeyer
Copy link
Member

So according to websocket-client/websocket-client#669 (comment), the changes made in websocket-client 0.58.0 will stay now, even with the proposed 1.0.0 release, right?
See websocket-client/websocket-client@3112b7d#commitcomment-47124551

@bastimeyer bastimeyer merged commit f5632b3 into streamlink:master Mar 20, 2021
Billy2011 added a commit to Billy2011/streamlink-27 that referenced this pull request Mar 21, 2021
@Billy2011
[PATCH] setup.py: require websocket-client>=0.58.0 (streamlink#3634)
a83cd31 
Make sure all User use the same version where `callback(self, *args)` was changed.

Ref websocket-client/websocket-client#669
Billy2011 added a commit to Billy2011/streamlink-27 that referenced this pull request Mar 21, 2021
@Billy2011
[PATCH] plugins.nicolive: fixed websocket-client (streamlink#3634)
83842ab
@back-to back-to deleted the websocket branch May 22, 2021 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
dependencies plugin issue A Plugin does not work correctly
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Potential issue with websocket-client >= 0.58 plugins.nicolive: handle_api_message() takes 2 positional arguments but 3 were given
2 participants
@back-to @bastimeyer