Skip to content

Broken wait_for_condition (some conditions need the switch_to api) #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 9, 2017
Merged

Broken wait_for_condition (some conditions need the switch_to api) #93

merged 3 commits into from
May 9, 2017

Conversation

ionelmc
Copy link
Member

@ionelmc ionelmc commented May 9, 2017

Example problem:

  File "/app/tests/test_func/test_ui.py", line 580, in test_foobar
    browser.wait_for_condition(expected_conditions.alert_is_present())
  File "/usr/local/lib/python2.7/dist-packages/pytest_splinter/plugin.py", line 50, in _wait_for_condition
    lambda browser: condition()
  File "/usr/local/lib/python2.7/dist-packages/selenium/webdriver/support/wait.py", line 71, in until
    value = method(self._driver)
  File "/usr/local/lib/python2.7/dist-packages/pytest_splinter/plugin.py", line 50, in <lambda>
    lambda browser: condition()
  File "/usr/local/lib/python2.7/dist-packages/selenium/webdriver/support/expected_conditions.py", line 338, in __call__
    alert = driver.switch_to.alert
AttributeError: 'WebDriver' object has no attribute 'switch_to'

@bubenkoff
Copy link
Member

please fix lint issue, also please add yourself to authors and add changelog entry

@bubenkoff bubenkoff merged commit 3ae9880 into master May 9, 2017
@bubenkoff
Copy link
Member

1.8.2 is out - thanks!

@ionelmc ionelmc deleted the ionelmc-patch-1 branch May 9, 2017 14:44
@ionelmc
Copy link
Member Author

ionelmc commented May 9, 2017

Wow that was quick!

@dependencies dependencies bot mentioned this pull request Jan 21, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bubenkoff bubenkoff bubenkoff approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ionelmc @bubenkoff