Add support for flat uint8 arrow arrays for multi channel images #8908
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radarhere
reviewed
Apr 18, 2025
radarhere
reviewed
Apr 18, 2025
radarhere
reviewed
Apr 18, 2025
wiredfool
changed the title
wiredfool
force-pushed
the
fix_arrow_8907
branch
from
02159f7 to
6bf791a
Compare
radarhere
reviewed
Apr 21, 2025
Co-authored-by: Andrew Murray <3112309+radarhere@users.noreply.github.com>
* edit of elt typ
radarhere
reviewed
May 24, 2025
| if (strcmp(schema->format, "C") == 0 // uint8 | ||
| && im->pixelsize == 4 // storage as 32 bpc | ||
| && schema->n_children == 0 // make sure schema is well formed. | ||
| && strcmp(im->arrow_band_format, "C") == 0 // Expected Format |
There was a problem hiding this comment.
Suggested change
| && strcmp(im->arrow_band_format, "C") == 0 // Expected Format | |
| && strcmp(im->arrow_band_format, "C") == 0 // expected format |
radarhere
reviewed
May 24, 2025
| px = img.load() | ||
| assert px is not None | ||
| if mask is None: | ||
| # have to do element wise comparison when we're comparing |
There was a problem hiding this comment.
Suggested change
| # have to do element wise comparison when we're comparing | |
| # have to do element-wise comparison when we're comparing |
radarhere
reviewed
May 24, 2025
| px = img.load() | ||
| assert px is not None | ||
| if elts_per_pixel > 1 and mask is None: | ||
| # have to do element wise comparison when we're comparing |
There was a problem hiding this comment.
Suggested change
| # have to do element wise comparison when we're comparing | |
| # have to do element-wise comparison when we're comparing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8907 .
Changes proposed in this pull request:
Image.fromarrowImage.fromarrow