Skip to content

Commit 9ad913e

Browse files
committed
typo + missing attr
1 parent 38352b3 commit 9ad913e

File tree

3 files changed

+17
-11
lines changed

3 files changed

+17
-11
lines changed

src/ImageStack/ImageManipulator/ConverterImageManipulator.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,8 +30,8 @@ class ConverterImageManipulator implements ImageManipulatorInterface, ImagineAwa
3030
*/
3131
public function __construct(ImagineInterface $imagine, array $conversions = [], array $options = [])
3232
{
33-
$this->setImagine($imagine, $options['imagine_options'] ?? []);
34-
unset($options['imagine_options']);
33+
$this->setImagine($imagine, $options['imagine_options'] ?? []);
34+
unset($options['imagine_options']);
3535
foreach ($conversions as $sourceMimeType => $destinationMimeType) {
3636
$this->addConversion($sourceMimeType, $destinationMimeType);
3737
}

src/ImageStack/ImageManipulator/ThumbnailRule/PatternThumbnailRule.php

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,12 @@ class PatternThumbnailRule implements ThumbnailRuleInterface, ImagineAwareInterf
3232
* @var string
3333
*/
3434
protected $format;
35+
36+
/**
37+
* A thumbnail filter.
38+
* @var string
39+
*/
40+
protected $filter;
3541

3642
/**
3743
* Pattern thumbnail rule constructor.

src/ImageStack/ImageManipulator/ThumbnailerImageManipulator.php

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -32,8 +32,8 @@ class ThumbnailerImageManipulator implements ImageManipulatorInterface {
3232
*/
3333
public function __construct(ImagineInterface $imagine, array $thumbnailRules = [], array $options = [])
3434
{
35-
$this->setImagine($imagine, $options['imagine_options'] ?? []);
36-
unset($options['imagine_options']);
35+
$this->setImagine($imagine, $options['imagine_options'] ?? []);
36+
unset($options['imagine_options']);
3737
foreach ($thumbnailRules as $thumbnailRule) {
3838
$this->addThumbnailRule($thumbnailRule);
3939
}
@@ -51,13 +51,13 @@ public function __construct(ImagineInterface $imagine, array $thumbnailRules = [
5151
*/
5252
public function addThumbnailRule(ThumbnailRuleInterface $thumbnailRule)
5353
{
54-
if ($thumbnailRule instanceof ImagineAwareInterface) {
54+
if ($thumbnailRule instanceof ImagineAwareInterface) {
5555
// not very LSP but handy
56-
if (!$thumbnailRule->getImagine()) {
57-
$thumbnailRule->setImagine($this->getImagine(), $this->getImagineOptions());
58-
}
59-
}
60-
$this->thumbnailRules[] = $thumbnailRule;
56+
if (!$thumbnailRule->getImagine()) {
57+
$thumbnailRule->setImagine($this->getImagine(), $this->getImagineOptions());
58+
}
59+
}
60+
$this->thumbnailRules[] = $thumbnailRule;
6161
}
6262

6363
/**
@@ -66,7 +66,7 @@ public function addThumbnailRule(ThumbnailRuleInterface $thumbnailRule)
6666
* @see \ImageStack\Api\ImageManipulatorInterface::manipulateImage()
6767
*/
6868
public function manipulateImage(ImageInterface $image, ImagePathInterface $path) {
69-
$this->_manipulateImage($image, $path);
69+
$this->_manipulateImage($image, $path);
7070
}
7171

7272
/**

0 commit comments

Comments
 (0)