Skip to content

Fix snmp v2 walk failure #37823

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

UTXOnly
Copy link

@UTXOnly UTXOnly commented Jun 10, 2025

What does this PR do?

  • Allows snmp walk subcommand to pull snmp_version: 2 from configuration to be used for troubleshooting

Motivation

  • snmp walk subcommand currently only supports SNMP version 2c, but snmp integration configuration only allows snmp_version: 2
❯ datadog-agent snmp walk 127.0.0.1:161 -v 2
Error: invalid argument "2" for "-v, --snmp-version" flag: must be one of 1|2c|3

Describe how you validated your changes

  • Added unit test to validate the SNMP v2 parameter

Possible Drawbacks / Trade-offs

Additional Notes

@UTXOnly UTXOnly requested a review from a team as a code owner June 10, 2025 15:10
@UTXOnly UTXOnly requested a review from jedupau June 10, 2025 15:10
@UTXOnly UTXOnly requested a review from a team as a code owner June 11, 2025 16:26
Copy link
Contributor

@rtrieu rtrieu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some feedback for your review re: spelling and grammar.

- |
List upgrade notes here, or remove this section.
Upgrade notes should be rare: only list known/potential breaking changes,
or major behaviorial changes that require user action before the upgrade.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
or major behaviorial changes that require user action before the upgrade.
or major behavioral changes that require user action before the upgrade.

List known issues here, or remove this section.
deprecations:
- |
List deprecations notes here, or remove this section.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
List deprecations notes here, or remove this section.
List deprecation notes here, or remove this section.

other:
- |
Add here every other information you want in the CHANGELOG that
don't fit in any other section. This section should rarely be
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
don't fit in any other section. This section should rarely be
doesn't fit in any other section. This section should rarely be

Fixes for SNMP v2 compatibility with the `snmpwalk` command.
other:
- |
Add here every other information you want in the CHANGELOG that
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Add here every other information you want in the CHANGELOG that
Add any other information you want in the CHANGELOG that

- |
List enhancements (new behavior that is too small to be
considered a new feature), or remove this section.
issues:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this be known issues or limitations?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants