Add systemd-boot bootchooser #1367
Conversation
obbardc
changed the title
obbardc
changed the title
obbardc
force-pushed
the
wip/obbardc/systemd-boot-bootchooser
branch
2 times, most recently
from
a5fa810 to
021b534
Compare
| } | ||
|
|
||
| /* Set the default boot choice to this slot name */ | ||
| /* TODO: allow the slot name to be configurable */ |
There was a problem hiding this comment.
Should add a config option for this.
There was a problem hiding this comment.
Shouldn't this be the slot's bootname?
Add some really basic support to set the EFI variable for systemd-boot's default boot choice EFI variable. This is currently set when `rauc status mark-good` is called; meaning that once the system has started successfully the default boot choice EFI variable will be updated to reflect from the next boot onwards. Signed-off-by: Christopher Obbard <chris.obbard@collabora.com>
obbardc
force-pushed
the
wip/obbardc/systemd-boot-bootchooser
branch
from
021b534 to
6c89078
Compare
Codecov ReportAttention: Patch coverage is
❌ Your patch check has failed because the patch coverage (16.00%) is below the target coverage (75.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## master #1367 +/- ##
==========================================
- Coverage 79.95% 79.87% -0.08%
==========================================
Files 67 67
Lines 20057 20082 +25
==========================================
+ Hits 16037 16041 +4
- Misses 4020 4041 +21 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
How would this interact with https://systemd.io/AUTOMATIC_BOOT_ASSESSMENT/, which is also implemented by systemd-boot? |
|
This would need to be rebased, as #1636 has split the bootloader backends into different files. |
Add some really basic support to set the EFI variable for systemd-boot's default boot choice EFI variable.
This is currently set when "rauc status mark-good" is called; meaning that once the system has started successfully the default boot choice EFI variable will be updated to reflect from the next boot onwards.
This PR needs (at least):
r_boot_get_state,r_boot_get_primary,r_boot_set_primaryFor context, this is from a project which we converted to use
systemd-bootfor its bootloader and is working quite well. I am creating a draft PR to see if there is any interest in accepting this into upstream, I can do all of the work to get it in.