fix EFI boot and duplicate strings, cleanup. #445
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…elopment Development->Master
…elopment Development->Master
…elopment Development
…elopment Development->Master
…elopment Development->Master
…elopment Development->Master
…elopment Development>Master
…elopment Development
…elopment Development>Master
…elopment Development -> Master
…elopment Development->Master
* Clean up YAML duplicate strings (unrelated) * Add proper `---` YAML document prefix (unrelated) * Placeholder PR for if we need to make adjustments for `uefi_$mode` hierarchy. related-to: redhat-performance#444
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## development #445 +/- ##
============================================
Coverage 91.39% 91.39%
============================================
Files 5 5
Lines 2428 2428
============================================
Hits 2219 2219
Misses 209 209
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
* They don't appear to do anything, our R660 are EFI-only anyway so just use those boot strings instead as normal.
sadsfae
changed the title
|
fixes: #444 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related-to: #444