plugins.telmadrid: add VOD URL to matcher tests, remove unnecessary dict() call, stop catching PluginError (for more detailed schema validation errors)

pablohoffman · pablohoffman · commit d24bb930c244 · 2023-03-02T18:46:14.000+01:00
diff --git a/src/streamlink/plugins/telemadrid.py b/src/streamlink/plugins/telemadrid.py
@@ -18,17 +18,14 @@
 class Telemadrid(Plugin):
 
     def _get_streams(self):
-        try:
-            data = self.session.http.get(self.url, schema=validate.Schema(
-                validate.parse_html(),
-                validate.xml_find(".//video[@class='video-js'][@data-video-id][@data-account][@data-player][1]"),
-                validate.union_get("data-video-id", "data-account", "data-player"),
-            ))
-        except PluginError:
-            return
+        data = self.session.http.get(self.url, schema=validate.Schema(
+            validate.parse_html(),
+            validate.xml_find(".//video[@class='video-js'][@data-video-id][@data-account][@data-player][1]"),
+            validate.union_get("data-video-id", "data-account", "data-player"),
+        ))
         data_video_id, data_account, data_player = data
         player = BrightcovePlayer(self.session, data_account, f"{data_player}_default")
-        return dict(player.get_streams(data_video_id))
+        return player.get_streams(data_video_id)
 
 
 __plugin__ = Telemadrid
diff --git a/tests/plugins/test_telemadrid.py b/tests/plugins/test_telemadrid.py
@@ -8,4 +8,5 @@ class TestPluginCanHandleUrlTelemadrid(PluginCanHandleUrl):
     should_match = [
         "https://www.telemadrid.es/",
         "https://www.telemadrid.es/emision-en-directo/",
+        "https://www.telemadrid.es/programas/telenoticias-1/Telenoticias-1-02032023-2-2538066218--20230302042202.html",
     ]

Original file line number	Diff line number	Diff line change
`@@ -8,4 +8,5 @@ class TestPluginCanHandleUrlTelemadrid(PluginCanHandleUrl):`
`8`	`8`	`should_match = [`
`9`	`9`	`"https://www.telemadrid.es/",`
`10`	`10`	`"https://www.telemadrid.es/emision-en-directo/",`
	`11`	`+ "https://www.telemadrid.es/programas/telenoticias-1/Telenoticias-1-02032023-2-2538066218--20230302042202.html",`
`11`	`12`	`]`