Upgrade to support electron 5 #364
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@alexstrat happy to take a look when this is in a reviewable state! |
alexstrat
force-pushed
the
upgrade-to-support-electron-5
branch
from
3b45197 to
54dc020
Compare
alexstrat
commented
Jun 1, 2019
test/accessibility-test.js
Outdated
| @@ -8,7 +8,7 @@ var it = global.it | |||
| var beforeEach = global.beforeEach | |||
| var afterEach = global.afterEach | |||
|
|
|||
| describe('app.client.auditAccessibility()', function () { | |||
| xdescribe('app.client.auditAccessibility()', function () { | |||
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
alexstrat
changed the title
|
@codebytere I think we're good here, ready for review! :) |
|
Is there any possibility of getting this merged and released soon? We've just updated to Electron 5 and our Spectron tests no longer work on Windows when running under Jenkins (our application never seems to start and the Jenkins job eventually times out). |
codebytere
approved these changes
Jun 20, 2019
|
cc @MarshallOfSound for secondary 👀, but then i think we can get this merged and released. |
|
@alexstrat i've merged and released compatibility for Thanks again for doing the work on this 🙇♀ it's very much appreciated! |
Implement workaround found https://bitbucket.org/chromiumembedded/cef/issues/2476/cef-webdriver-instructions-will-need-to
nodeIntegration is now defaultly false in v5
alexstrat
force-pushed
the
upgrade-to-support-electron-5
branch
from
5e540b3 to
b5a1468
Compare
|
@codebytere rebased ✅ |
|
👏 clap |
mikesbrown
added a commit
to brimdata/zui
that referenced
this pull request
Apr 16, 2020
This was originally employed to work around Spectron choosing a random port colliding with our back end. Spectron's choosing a random port was in turn used as an Electron workaround. The workarounds haven't been needed since Electron 5. We moved past Electron 4 at #381 . This effectively reverts #319 Other refs: electron-userland/spectron#361 electron-userland/spectron#364
mikesbrown
added a commit
to brimdata/zui
that referenced
this pull request
Apr 16, 2020
This was originally employed to work around Spectron choosing a random port colliding with our back end. Spectron's choosing a random port was in turn used as an Electron workaround. The workarounds haven't been needed since Electron 5. We moved past Electron 4 at #381 . This effectively reverts #319 Other refs: electron-userland/spectron#361 electron-userland/spectron#364
alfred-landrum
pushed a commit
to brimdata/zui
that referenced
this pull request
Apr 17, 2020
This was originally employed to work around Spectron choosing a random port colliding with our back end. Spectron's choosing a random port was in turn used as an Electron workaround. The workarounds haven't been needed since Electron 5. We moved past Electron 4 at #381 . This effectively reverts #319 Other refs: electron-userland/spectron#361 electron-userland/spectron#364
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #361
Todos
nodeIntegration+ versionsCannot read property 'isLoading' of undefinedinvalid session id