[Silabs] Add silabs zephyr light #39998
Open
+706
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jepenven-silabs
force-pushed
the
silabs_zephyr_lighting
branch
from
400226c to
30e4db0
Compare
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a new lighting-app example for Zephyr on Silabs platforms. The changes are extensive, including new source code, build scripts, and documentation. The overall structure is good, but I've found a few issues, including some high-severity configuration problems that could lead to build failures, and some areas in the documentation that could be clearer. Addressing these points will improve the quality and usability of the new example.
examples/lighting-app/silabs/zephyr/boards/siwx917_rb4338a.overlay
Outdated
Show resolved
Hide resolved
|
PR #39998: Size comparison from eb24758 to d0402ea Full report (70 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
jmartinez-silabs
approved these changes
Jul 14, 2025
| #### Commission the device over BLE-WiFi: | ||
|
|
||
| ```bash | ||
| ./out/linux-x64-chip-tool/chip-tool pairing ble-wifi 1 ${SSID} ${PASSWORD} 20202021 3840 |
There was a problem hiding this comment.
Suggested change
| ./out/linux-x64-chip-tool/chip-tool pairing ble-wifi 1 ${SSID} ${PASSWORD} 20202021 3840 | |
| ./out/linux-x64-chip-tool/chip-tool pairing ble-wifi ${NODE_ID} ${SSID} ${PASSWORD} 20202021 3840 |
|
|
||
| ```bash | ||
| # Turn on the light | ||
| ./out/linux-x64-chip-tool/chip-tool onoff on 1 1 |
There was a problem hiding this comment.
I guess if {NODE_ID} is used as suggested above the follow-up command should use that too
|
|
||
| Where: | ||
|
|
||
| - `1` is the node ID assigned to the device |
There was a problem hiding this comment.
That works too. As you prefer.
| @@ -0,0 +1,57 @@ | |||
| /* | |||
| * Copyright (c) 2024 Project CHIP Authors | |||
There was a problem hiding this comment.
Suggested change
| * Copyright (c) 2024 Project CHIP Authors | |
| * Copyright (c) 2025 Project CHIP Authors |
| @@ -0,0 +1,69 @@ | |||
| # | |||
| # Copyright (c) 2022 Project CHIP Authors | |||
There was a problem hiding this comment.
Suggested change
| # Copyright (c) 2022 Project CHIP Authors | |
| # Copyright (c) 2025 Project CHIP Authors |
| @@ -0,0 +1,27 @@ | |||
| # | |||
| # Copyright (c) 2022 Project CHIP Authors | |||
There was a problem hiding this comment.
Suggested change
| # Copyright (c) 2022 Project CHIP Authors | |
| # Copyright (c) 2025 Project CHIP Authors |
PR template asks for a bit more details about what was tested to help reviewers in their duty |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add Lighting-app application for Zephyr
Does not work yet as is since the whole Zephyr support was broken down into multiples small PR.
Related issues
none
Testing
Tested internally at Silicon Labs