Skip to content

Typo in unstake coins tx logs and counts #153

New issue
New issue
Open
Open
Typo in unstake coins tx logs and counts#153
@chrypnotoad

Description

@chrypnotoad
chrypnotoad
opened on Aug 30, 2024

The following logs and counts mention stake coins tx but should be unstake coins tx looks like a copy and paste error.

shardeum/src/setup/validateTxnFields.ts

Lines 409 to 425 in b350e7c

if (appData && appData.internalTx && appData.internalTXType === InternalTXType.Unstake) {
nestedCountersInstance.countEvent('shardeum-unstaking', 'validating unstake coins tx fields')
if (ShardeumFlags.VerboseLogs) console.log('Validating unstake coins tx fields', appData.internalTx)
const unstakeCoinsTX = appData.internalTx as UnstakeCoinsTX
if (
unstakeCoinsTX.nominator == null ||
unstakeCoinsTX.nominator.toLowerCase() !== senderAddress.toString()
) {
/* prettier-ignore */ nestedCountersInstance.countEvent( 'shardeum-unstaking', 'invalid nominator address in stake coins tx' )
/* prettier-ignore */ if (ShardeumFlags.VerboseLogs) console.log( `nominator vs tx signer`, unstakeCoinsTX.nominator, senderAddress.toString() )
success = false
reason = `Invalid nominator address in stake coins tx`
} else if (unstakeCoinsTX.nominee == null) {
/* prettier-ignore */ nestedCountersInstance.countEvent( 'shardeum-unstaking', 'invalid nominee address in stake coins tx' )
success = false
reason = `Invalid nominee address in stake coins tx`
}

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions