Skip to content

plugins.sbscokr: rewrite and fix plugin #4865

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 4, 2022
Merged

plugins.sbscokr: rewrite and fix plugin #4865

merged 1 commit into from
Oct 4, 2022

Conversation

bastimeyer
Copy link
Member

I noticed the --sbscokr-id plugin argument while cleaning up some plugins, and apparently it's not needed anymore as the individual streams are accessible from a canonical URL now.

This PR therefore suppresses the plugin argument. The old implementation also didn't support "virtual" channels which are retrieved from a different API endpoint. Geo-restriction seems to depend on the content that's currently being shown.

master

$ streamlink https://play.sbs.co.kr/onair/pc/index.html --sbscokr-id S01
[cli][info] Found matching plugin sbscokr for URL https://play.sbs.co.kr/onair/pc/index.html
[plugins.sbscokr][info] Available IDs: S01 (SBS), S02 (SBS Sports), S03 (SBS Plus), S04 (SBS funE), S05 (SBS Golf), S06 (SBS BIZ), S07 (POWER FM), S08 (LOVE FM), S09 (SBS M), S10 (Kizmom), S17 (POWER FM), S18 (LOVE FM), S19 (GorealraM), S20 (K POP)
[plugins.sbscokr][error] We’re sorry, it’s permitted to see this content in South Korea only.
error: No playable streams found on this URL: https://play.sbs.co.kr/onair/pc/index.html

$ streamlink https://play.sbs.co.kr/onair/pc/index.html --sbscokr-id S21
[cli][info] Found matching plugin sbscokr for URL https://play.sbs.co.kr/onair/pc/index.html
[plugins.sbscokr][info] Available IDs: S01 (SBS), S02 (SBS Sports), S03 (SBS Plus), S04 (SBS funE), S05 (SBS Golf), S06 (SBS BIZ), S07 (POWER FM), S08 (LOVE FM), S09 (SBS M), S10 (Kizmom), S17 (POWER FM), S18 (LOVE FM), S19 (GorealraM), S20 (K POP)
[plugins.sbscokr][error] Channel ID "S21" is not available.
error: No playable streams found on this URL: https://play.sbs.co.kr/onair/pc/index.html

PR

$ streamlink https://www.sbs.co.kr/live/S01
[cli][info] Found matching plugin sbscokr for URL https://www.sbs.co.kr/live/S01
[plugins.sbscokr][error] Geo-restricted content: We’re sorry, it’s permitted to see this content in South Korea only.
error: No playable streams found on this URL: https://www.sbs.co.kr/live/S01

$ streamlink https://www.sbs.co.kr/live/S21
[cli][info] Found matching plugin sbscokr for URL https://www.sbs.co.kr/live/S21
Available streams: 720p (worst, best)

$ streamlink https://www.sbs.co.kr/live/foo
[cli][info] Found matching plugin sbscokr for URL https://www.sbs.co.kr/live/foo
error: No playable streams found on this URL: https://www.sbs.co.kr/live/foo

@bastimeyer bastimeyer added plugin enhancement A new feature for a working Plugin cleanup labels Oct 4, 2022
@Richiwer Richiwer mentioned this pull request Oct 4, 2022
Open
@gravyboat gravyboat merged commit d17cf06 into streamlink:master Oct 4, 2022
@bastimeyer bastimeyer deleted the plugins/sbscokr/rewrite branch October 4, 2022 06:44
Billy2011 added a commit to Billy2011/streamlink-27 that referenced this pull request Oct 6, 2022
@Billy2011
[PATCH] plugins.sbscokr: rewrite and fix plugin(streamlink#4865)
55bda6c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cleanup plugin enhancement A new feature for a working Plugin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bastimeyer @gravyboat