Fix 582: support error_prone's @CanIgnoreReturnValue with guava < 23.6-jre #592
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
previous implementation does not use annotation on method, and refer annotation on package directly. to use CanIgnoreReturnValue annotation on method, we should check annotation on method first.
KengoTODA
added a commit
that referenced
this pull request
Mar 22, 2018
|
@spotbugs/everyone could you review? |
wmm, I cannot solve this message... my local Git says that we have no conflicts between two branches. |
KengoTODA
added a commit
that referenced
this pull request
Apr 3, 2018
commit bb43071 Merge: 9747507 f1e14af Author: Kengo TODA <skypencil@gmail.com> Date: Mon Apr 2 17:50:50 2018 +0800 Merge remote-tracking branch 'spotbugs/release-3.1' into fix-582 commit 9747507 Author: Kengo TODA <skypencil@gmail.com> Date: Thu Mar 22 10:22:54 2018 +0800 refs #592: follow suggestion from SonarQube commit 13656e8 Author: Kengo TODA <skypencil@gmail.com> Date: Wed Mar 21 18:29:02 2018 +0800 refs #592: follow suggestion from SonarQube commit 37c5c29 Author: Kengo TODA <skypencil@gmail.com> Date: Wed Mar 21 18:02:52 2018 +0800 refs #582: update CHANGELOG commit 0bbc040 Author: Kengo TODA <skypencil@gmail.com> Date: Wed Mar 21 18:00:11 2018 +0800 refs #582: remove debug log commit e0e1895 Author: Kengo TODA <skypencil@gmail.com> Date: Wed Mar 21 17:55:41 2018 +0800 fix #582: support CheckReturnValue annotation from errorprone commit 39f4c50 Author: Kengo TODA <skypencil@gmail.com> Date: Wed Mar 21 17:34:26 2018 +0800 refs #582: support annotation on package-info.class commit cdc0a8f Author: Kengo TODA <skypencil@gmail.com> Date: Wed Mar 21 17:31:05 2018 +0800 refs #582: refer annotation on method, then refer it on package previous implementation does not use annotation on method, and refer annotation on package directly. to use CanIgnoreReturnValue annotation on method, we should check annotation on method first. commit 04e5df7 Author: Kengo TODA <skypencil@gmail.com> Date: Wed Mar 21 11:57:19 2018 +0800 refs #582: reproduce reported problem
henrik242
pushed a commit
that referenced
this pull request
Apr 3, 2018
commit bb43071 Merge: 9747507 f1e14af Author: Kengo TODA <skypencil@gmail.com> Date: Mon Apr 2 17:50:50 2018 +0800 Merge remote-tracking branch 'spotbugs/release-3.1' into fix-582 commit 9747507 Author: Kengo TODA <skypencil@gmail.com> Date: Thu Mar 22 10:22:54 2018 +0800 refs #592: follow suggestion from SonarQube commit 13656e8 Author: Kengo TODA <skypencil@gmail.com> Date: Wed Mar 21 18:29:02 2018 +0800 refs #592: follow suggestion from SonarQube commit 37c5c29 Author: Kengo TODA <skypencil@gmail.com> Date: Wed Mar 21 18:02:52 2018 +0800 refs #582: update CHANGELOG commit 0bbc040 Author: Kengo TODA <skypencil@gmail.com> Date: Wed Mar 21 18:00:11 2018 +0800 refs #582: remove debug log commit e0e1895 Author: Kengo TODA <skypencil@gmail.com> Date: Wed Mar 21 17:55:41 2018 +0800 fix #582: support CheckReturnValue annotation from errorprone commit 39f4c50 Author: Kengo TODA <skypencil@gmail.com> Date: Wed Mar 21 17:34:26 2018 +0800 refs #582: support annotation on package-info.class commit cdc0a8f Author: Kengo TODA <skypencil@gmail.com> Date: Wed Mar 21 17:31:05 2018 +0800 refs #582: refer annotation on method, then refer it on package previous implementation does not use annotation on method, and refer annotation on package directly. to use CanIgnoreReturnValue annotation on method, we should check annotation on method first. commit 04e5df7 Author: Kengo TODA <skypencil@gmail.com> Date: Wed Mar 21 11:57:19 2018 +0800 refs #582: reproduce reported problem
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To fix #582, we need to fix two problems:
@CheckReturnValueannotation is not supported (this is feature improvement)CheckReturnAnnotationDatabasedoes not handle annotation onpackage-info.class(this is bugfix)