Skip to content

Revisit sorting of repair queue items #7509

Open
@elek

Description

@elek
  1. RS min=7 with 9 healthy pieces are lower priority right now compared to min=29 and healthy=39
func TestMore(t *testing.T) {
	const failureRate = 0.00005435
	fmt.Println(repair.SegmentHealth(39, 29, 20000, failureRate, 0))
	fmt.Println(repair.SegmentHealth(9, 7, 20000, failureRate, 0))
}

5060.05059797608
5520.055197792089

I would expect the opposite: 7/9 should be repaired ASAP.

This explains why did we see un-repaired items in durability report

  1. Different number of retrievable pieces supposed to have different priorities:
Job ID: A Healthy: 10, Retrievable: 17, OOP: 0, Health: 5059.967161
Job ID: B, Healthy: 10, Retrievable: 17, OOP: 0, Health: 5059.967161
Job ID: C, Healthy: 10, Retrievable: 21, OOP: 0, Health: 5059.967161
Job ID: D, Healthy: 10, Retrievable: 18, OOP: 0, Health: 5059.967161
Job ID: E, Healthy: 10, Retrievable: 18, OOP: 0, Health: 5059.967161
Job ID: F, Healthy: 10, Retrievable: 15, OOP: 0, Health: 5059.967161
Job ID: G, Healthy: 10, Retrievable: 14, OOP: 0, Health: 5059.967167
Job ID: H, Healthy: 10, Retrievable: 15, OOP: 0, Health: 5059.967167
Job ID: I, Healthy: 10, Retrievable: 19, OOP: 0, Health: 5059.967167
Job ID: J, Healthy: 10, Retrievable: 17, OOP: 0, Health: 5059.967167

Having only 14 retrievable instead of 19 is more risky.

See earlier discussion in: https://review.dev.storj.tools/c/storj/storj/+/11885?tab=comments

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions