⚡️ Speed up function process_result by 12% in PR #3819 (feature/defer)

codeflash-ai[bot] · web-flow · commit f53d840ab6e9 · 2025-07-01T11:11:31.000Z
Here is an optimized version. Improvements.

- Removed the unnecessary intermediate variables (`errors`, `extensions`) that are only used once.
- Avoided repeated dictionary unpacking by building the dictionary with direct assignments and only adding keys if necessary.
- Used `if-else` statements for error and extensions blocks for slight speed-ups over dictionary unpacking on small dicts.

Rewritten code.



This version allocates less intermediate data and does not do work unless necessary.
diff --git a/strawberry/http/__init__.py b/strawberry/http/__init__.py
@@ -20,12 +20,11 @@ def process_result(result: ResultType) -> GraphQLHTTPResponse:
     if isinstance(result, GraphQLIncrementalExecutionResults):
         return result
 
-    errors, extensions = result.errors, result.extensions
-    data: GraphQLHTTPResponse = {
-        "data": result.data,
-        **({"errors": [err.formatted for err in errors]} if errors else {}),
-        **({"extensions": extensions} if extensions else {}),
-    }
+    data: GraphQLHTTPResponse = {"data": result.data}
+    if result.errors:
+        data["errors"] = [err.formatted for err in result.errors]
+    if result.extensions:
+        data["extensions"] = result.extensions
 
     return data
 
