tools: force LF line endings via .gitattributes

bastimeyer · gravyboat · commit 374130a4de67 · 2020-12-25T11:49:38.000-08:00
https://stackoverflow.com/questions/29435156 - add additional linting steps to Github actions for checking the line endings and file permissions - fix line endings and file permissions
diff --git a/.gitattributes b/.gitattributes
@@ -1 +1,2 @@
+* text=auto eol=lf
 src/streamlink/_version.py export-subst
diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml
@@ -35,9 +35,15 @@ jobs:
       - name: Install dependencies
         continue-on-error: ${{ matrix.continue || false }}
         run: bash ./script/install-dependencies.sh
-      - name: Lint
+      - name: Lint (flake8)
         continue-on-error: ${{ matrix.continue || false }}
         run: flake8 --count
+      - name: Lint (line terminators)
+        if: startsWith(matrix.os, 'ubuntu')
+        run: "! grep 'with CRLF line terminators' <(git ls-files | file -nNf-)"
+      - name: Lint (file permissions)
+        if: startsWith(matrix.os, 'ubuntu')
+        run: "! grep -Ev '^644' <(git ls-files src/ tests/ | xargs stat '--format=%a %n')"
       - name: Test
         continue-on-error: ${{ matrix.continue || false }}
         run: pytest -r a --cov --cov-branch --cov-report=xml
diff --git a/tests/plugins/test_vk.py b/tests/plugins/test_vk.py
diff --git a/tests/plugins/test_webcast_india_gov.py b/tests/plugins/test_webcast_india_gov.py
@@ -1,16 +1,16 @@
-import unittest
-
-from streamlink.plugins.webcast_india_gov import WebcastIndiaGov
-
-
-class TestPluginWebcastIndiaGov(unittest.TestCase):
-    def test_can_handle_url(self):
-        # should match
-        self.assertTrue(WebcastIndiaGov.can_handle_url("http://webcast.gov.in/ddpunjabi/"))
-        self.assertTrue(WebcastIndiaGov.can_handle_url("http://webcast.gov.in/#Channel1"))
-        self.assertTrue(WebcastIndiaGov.can_handle_url("http://webcast.gov.in/#Channel3"))
-
-        # shouldn't match
-        self.assertFalse(WebcastIndiaGov.can_handle_url("http://meity.gov.in/"))
-        self.assertFalse(WebcastIndiaGov.can_handle_url("http://www.nic.in/"))
-        self.assertFalse(WebcastIndiaGov.can_handle_url("http://digitalindiaawards.gov.in/"))
+import unittest
+
+from streamlink.plugins.webcast_india_gov import WebcastIndiaGov
+
+
+class TestPluginWebcastIndiaGov(unittest.TestCase):
+    def test_can_handle_url(self):
+        # should match
+        self.assertTrue(WebcastIndiaGov.can_handle_url("http://webcast.gov.in/ddpunjabi/"))
+        self.assertTrue(WebcastIndiaGov.can_handle_url("http://webcast.gov.in/#Channel1"))
+        self.assertTrue(WebcastIndiaGov.can_handle_url("http://webcast.gov.in/#Channel3"))
+
+        # shouldn't match
+        self.assertFalse(WebcastIndiaGov.can_handle_url("http://meity.gov.in/"))
+        self.assertFalse(WebcastIndiaGov.can_handle_url("http://www.nic.in/"))
+        self.assertFalse(WebcastIndiaGov.can_handle_url("http://digitalindiaawards.gov.in/"))

Original file line number	Diff line number	Diff line change
`@@ -1 +1,2 @@`
	`1`	`+* text=auto eol=lf`
`1`	`2`	`src/streamlink/_version.py export-subst`